[Merged by Bors] - feat(Order/Zorn): change zorn to use Maximal API#14781
Closed
[Merged by Bors] - feat(Order/Zorn): change zorn to use Maximal API#14781
Conversation
PR summary f665fa8f24
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Order.Zorn | 344 | 352 | +8 (+2.33%) |
| Mathlib.Order.Extension.Linear | 345 | 353 | +8 (+2.32%) |
| Mathlib.SetTheory.Cardinal.SchroederBernstein | 382 | 390 | +8 (+2.09%) |
| Mathlib.Order.ZornAtoms | 362 | 365 | +3 (+0.83%) |
| Mathlib.Order.PrimeSeparator | 402 | 403 | +1 (+0.25%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Order.PrimeSeparator |
1 |
Mathlib.Order.ZornAtoms |
3 |
3 filesMathlib.Order.Zorn Mathlib.SetTheory.Cardinal.SchroederBernstein Mathlib.Order.Extension.Linear |
8 |
Declarations diff
+ zorn_le
+ zorn_le_nonempty
+ zorn_le_nonempty_Ici₀
+ zorn_le_nonempty₀
+ zorn_le₀
- zorn_nonempty_Ici₀
- zorn_nonempty_partialOrder
- zorn_nonempty_partialOrder₀
- zorn_nonempty_preorder
- zorn_nonempty_preorder₀
- zorn_partialOrder
- zorn_partialOrder₀
- zorn_preorder
- zorn_preorder₀
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
j-loreaux
reviewed
Aug 7, 2024
Contributor
j-loreaux
left a comment
There was a problem hiding this comment.
Looks relatively reasonable, but here are some comments.
Comment on lines
+66
to
+67
| obtain ⟨Jset, _, hmax⟩ := zorn_subset_nonempty S chainub I IinS | ||
| obtain ⟨Jidl, IJ, JF⟩ := hmax.prop |
Contributor
There was a problem hiding this comment.
I see this pattern a lot in this PR. Should we just have an additional lemma besides zorn_subset_nonempty that does the second step deconstruction too?
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Contributor
|
LGTM now. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by j-loreaux. |
Contributor
|
!bench |
Collaborator
|
Here are the benchmark results for commit f665fa8. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
We change statements of Zorn's lemma to use the new `Maximal` API from #14721. The new definitions eliminate the need for separate `PartialOrder` and `Preorder` versions of Zorn's lemma, and slightly simplify most of its applications. The new statements of Zorn aren't defeq to the old ones, so a good number of files are touched, but very few theorem statements outside `Order.Zorn` itself are actually changed - most changes are small modifications of existing proofs. - [x] depends on: #14721
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
We change statements of Zorn's lemma to use the new `Maximal` API from #14721. The new definitions eliminate the need for separate `PartialOrder` and `Preorder` versions of Zorn's lemma, and slightly simplify most of its applications. The new statements of Zorn aren't defeq to the old ones, so a good number of files are touched, but very few theorem statements outside `Order.Zorn` itself are actually changed - most changes are small modifications of existing proofs. - [x] depends on: #14721
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
We change statements of Zorn's lemma to use the new `Maximal` API from #14721. The new definitions eliminate the need for separate `PartialOrder` and `Preorder` versions of Zorn's lemma, and slightly simplify most of its applications. The new statements of Zorn aren't defeq to the old ones, so a good number of files are touched, but very few theorem statements outside `Order.Zorn` itself are actually changed - most changes are small modifications of existing proofs. - [x] depends on: #14721
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
We change statements of Zorn's lemma to use the new `Maximal` API from #14721. The new definitions eliminate the need for separate `PartialOrder` and `Preorder` versions of Zorn's lemma, and slightly simplify most of its applications. The new statements of Zorn aren't defeq to the old ones, so a good number of files are touched, but very few theorem statements outside `Order.Zorn` itself are actually changed - most changes are small modifications of existing proofs. - [x] depends on: #14721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We change statements of Zorn's lemma to use the new
MaximalAPI from #14721. The new definitions eliminate the need for separatePartialOrderandPreorderversions of Zorn's lemma, and slightly simplify most of its applications.The new statements of Zorn aren't defeq to the old ones, so a good number of files are touched, but very few theorem statements outside
Order.Zornitself are actually changed - most changes are small modifications of existing proofs.