Skip to content

[Merged by Bors] - chore(UniformEmbedding): add UniformInducing.uniformInducing_iff#14742

Closed
urkud wants to merge 3 commits intomasterfrom
YK-uniformInducing-iff
Closed

[Merged by Bors] - chore(UniformEmbedding): add UniformInducing.uniformInducing_iff#14742
urkud wants to merge 3 commits intomasterfrom
YK-uniformInducing-iff

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jul 15, 2024


Open in Gitpod

@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jul 15, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 15, 2024

PR summary 0d4baaafe8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ UniformInducing.uniformInducing_comp_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Comment on lines +110 to +111
protected theorem UniformInducing.uniformInducing_iff {f : α → β} {g : β → γ}
(hg : UniformInducing g) : UniformInducing f ↔ UniformInducing (g ∘ f) := by
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you exchange the two sides of the iff, and rename the lemma to UniformInducing.uniformInducing_comp_iff?

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 15, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 15, 2024
@urkud urkud added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Jul 15, 2024
@ghost
Copy link
Copy Markdown

ghost commented Jul 15, 2024

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(UniformEmbedding): add UniformInducing.uniformInducing_iff [Merged by Bors] - chore(UniformEmbedding): add UniformInducing.uniformInducing_iff Jul 15, 2024
@mathlib-bors mathlib-bors bot closed this Jul 15, 2024
@mathlib-bors mathlib-bors bot deleted the YK-uniformInducing-iff branch July 15, 2024 19:24
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants