[Merged by Bors] - chore: move non @[to_additive] parts of Algebra.Order.Monoid and Algebra.Order.Group to a different file#14667
Closed
Command-Master wants to merge 7 commits intomasterfrom
Closed
Conversation
Collaborator
Author
|
!bench |
Algebra.Order.Monoid and Algebra.Order.Group to a different file@[to_additive] parts of Algebra.Order.Monoid and Algebra.Order.Group to a different file
PR summary 43f21e04c8
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Group.WithTop | 202 | 0 | -202 (-100.00%) |
| Mathlib.Algebra.Order.Monoid.WithTop | 198 | 181 | -17 (-8.59%) |
| Mathlib.Algebra.PUnitInstances.Order | 345 | 358 | +13 (+3.77%) |
| Mathlib.Data.Nat.Cast.WithTop | 235 | 239 | +4 (+1.70%) |
| Mathlib.Algebra.Order.Sub.WithTop | 200 | 203 | +3 (+1.50%) |
| Mathlib.Algebra.CharZero.Lemmas | 408 | 412 | +4 (+0.98%) |
| Mathlib.Algebra.Order.GroupWithZero.Canonical | 352 | 355 | +3 (+0.85%) |
| Mathlib.Data.Finset.Fold | 411 | 414 | +3 (+0.73%) |
| Mathlib.Algebra.Order.Monoid.Defs | 180 | 179 | -1 (-0.56%) |
| Mathlib.Algebra.Order.Group.Defs | 183 | 182 | -1 (-0.55%) |
Import changes for all files
| Files | Import difference |
|---|---|
| Too many changes (3112)! |
Declarations diff
++-- coe_eq_ofNat
++-- coe_nat
++-- coe_ofNat
++-- map_add
++-- ofNat_eq_coe
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
YaelDillies
reviewed
Jul 12, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Contributor
|
Thanks! I think that's a pretty good split, and the new file is not too big. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Collaborator
|
Here are the benchmark results for commit e31785e. Benchmark Metric Change
=============================================================
+ ~Mathlib.Algebra.Order.Monoid.WithTop instructions -77.1%
- ~Mathlib.CategoryTheory.Monoidal.Mon_ instructions 4.8% |
Contributor
|
Hmm, that performance in |
Member
|
But not too problematic, I think. bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
…`Algebra.Order.Group` to a different file (#14667) Following the discussion on #14598, move `LinearOrderedAddCommMonoidWithTop`, `LinearOrderedAddCommGroupWithTop`, and associated theorems to `Algebra.Order.AddGroupWithTop`. Co-authored-by: Daniel Weber <55664973+Command-Master@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
@[to_additive] parts of Algebra.Order.Monoid and Algebra.Order.Group to a different file@[to_additive] parts of Algebra.Order.Monoid and Algebra.Order.Group to a different file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion on #14598, move
LinearOrderedAddCommMonoidWithTop,LinearOrderedAddCommGroupWithTop, and associated theorems toAlgebra.Order.AddGroupWithTop.