[Merged by Bors] - chore: Move smooth_barycentric_coord#14666
Closed
YaelDillies wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore: Move smooth_barycentric_coord#14666YaelDillies wants to merge 1 commit intomasterfrom
smooth_barycentric_coord#14666YaelDillies wants to merge 1 commit intomasterfrom
Conversation
Moving it to a new file `Analysis.Calculus.AddTorsor.Coord` significantly reduces the imports to `Analysis.NormedSpace.AddTorsorBases`. Move * `Analysis.Calculus.AffineMap` to `Analysis.Calculus.AddTorsor.AffineMap`
PR summary 6feb86efce
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Analysis.NormedSpace.AddTorsorBases | 1496 | 1461 | -35 (-2.34%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Analysis.Calculus.AffineMap |
-1305 |
Mathlib.Analysis.Convex.Intrinsic Mathlib.Analysis.NormedSpace.AddTorsorBases |
-35 |
Mathlib.MeasureTheory.Group.GeometryOfNumbers Mathlib.Analysis.Convex.Measure |
-21 |
10 filesMathlib.NumberTheory.Cyclotomic.Rat Mathlib.NumberTheory.Cyclotomic.Discriminant Mathlib.NumberTheory.NumberField.Discriminant Mathlib.NumberTheory.Cyclotomic.Three Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.NumberField.CanonicalEmbedding.ConvexBody Mathlib.NumberTheory.Cyclotomic.PID Mathlib.NumberTheory.NumberField.Units.DirichletTheorem Mathlib.NumberTheory.NumberField.Units.Regulator Mathlib.NumberTheory.NumberField.ClassNumber |
-3 |
Mathlib.Analysis.Calculus.AddTorsor.AffineMap |
1305 |
Mathlib.Analysis.Calculus.AddTorsor.Coord |
1497 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
3 tasks
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Moving it to a new file `Analysis.Calculus.AddTorsor.Coord` significantly reduces the imports to `Analysis.NormedSpace.AddTorsorBases`. Also rename `Analysis.Calculus.AffineMap` to `Analysis.Calculus.AddTorsor.AffineMap`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
smooth_barycentric_coordsmooth_barycentric_coord
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving it to a new file
Analysis.Calculus.AddTorsor.Coordsignificantly reduces the imports toAnalysis.NormedSpace.AddTorsorBases. Also renameAnalysis.Calculus.AffineMaptoAnalysis.Calculus.AddTorsor.AffineMap.