Skip to content

[Merged by Bors] - chore: remove unused lemmas about bit0/1#14661

Closed
Ruben-VandeVelde wants to merge 1 commit intomasterfrom
deprecated-bits
Closed

[Merged by Bors] - chore: remove unused lemmas about bit0/1#14661
Ruben-VandeVelde wants to merge 1 commit intomasterfrom
deprecated-bits

Conversation

@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde commented Jul 11, 2024

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added easy < 20s of review time. See the lifecycle page for guidelines. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jul 11, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 11, 2024

PR summary eb38ce18a4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- bit0_apply
- bit1_apply
- bit1_apply_eq
- bit1_apply_ne
- lift_bit0
- lift_bit1
- power_bit0
- power_bit1
-- cast_bit0
-- cast_bit1
-- coe_bit0
-- coe_bit1

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

grunweg
grunweg reviewed Jul 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 11, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 11, 2024
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Jul 12, 2024

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 12, 2024
@Ruben-VandeVelde
chore: remove unused lemmas about bit0/1 (#14661)
79b532c
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove unused lemmas about bit0/1 [Merged by Bors] - chore: remove unused lemmas about bit0/1 Jul 12, 2024
@mathlib-bors mathlib-bors bot closed this Jul 12, 2024
@mathlib-bors mathlib-bors bot deleted the deprecated-bits branch July 12, 2024 04:44
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunweg grunweg grunweg left review comments

@jcommelin jcommelin Awaiting requested review from jcommelin

Assignees

No one assigned

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ruben-VandeVelde @jcommelin @grunweg