Skip to content

[Merged by Bors] - chore: remove superfluous intros#14614

Closed
mo271 wants to merge 2 commits intomasterfrom
mo271/superfluous_intros
Closed

[Merged by Bors] - chore: remove superfluous intros#14614
mo271 wants to merge 2 commits intomasterfrom
mo271/superfluous_intros

Conversation

@mo271
Copy link
Copy Markdown
Collaborator

@mo271 mo271 commented Jul 10, 2024

Open in Gitpod

@mo271 mo271 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. awaiting-review labels Jul 10, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 10, 2024 •
edited
Loading

PR summary 0abc04ad7b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 10, 2024
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jul 10, 2024

!bench

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jul 10, 2024

FYI, the awaiting-review label was recently removed: you can simply omit it now. (See zulip for details.)

grunweg
grunweg reviewed Jul 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! These changes look good; I have one follow-up request.
Out of paranoia, I'd like to see if this makes any difference performance-wise; otherwise, this is good to go.

@grunweg grunweg added awaiting-author A reviewer has asked the author a question or requested changes. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 10, 2024
@grunweg grunweg self-assigned this Jul 10, 2024
@leanprover-bot
Copy link
Copy Markdown
Collaborator

leanprover-bot commented Jul 10, 2024

Here are the benchmark results for commit 8ba9e11.
There were no significant changes against commit e242f1e.

@grunweg grunweg removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 10, 2024
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jul 10, 2024

No performance effect - if you fix the nit, this is ready to be merged.

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jul 12, 2024

Thanks again for your contribution!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 12, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 12, 2024
@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 12, 2024
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Jul 12, 2024

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 12, 2024
@mo271
chore: remove superfluous intros (#14614)
e2113ef 
Co-authored-by: Moritz Firsching <firsching@google.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove superfluous intros [Merged by Bors] - chore: remove superfluous intros Jul 12, 2024
@mathlib-bors mathlib-bors bot closed this Jul 12, 2024
@mathlib-bors mathlib-bors bot deleted the mo271/superfluous_intros branch July 12, 2024 09:29
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunweg grunweg grunweg left review comments

Assignees

@grunweg grunweg

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mo271 @grunweg @leanprover-bot @jcommelin