[Merged by Bors] - fix: silence the set_option linter outside of mathlib#14558
Closed
[Merged by Bors] - fix: silence the set_option linter outside of mathlib#14558
set_option linter outside of mathlib#14558Conversation
PR summary 2121c4b14dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Contributor
|
Implementation looks good to me. |
set_option linter outisde of mathlibset_option linter outside of mathlib
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
This PR makes the `set_option` linter only emit its warnings in files whose path begins with `Mathlib`, `test`, `Archive`, `Counterexamples`. Effectively, it should disable the linter on projects that are not mathlib. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/.60pp.2Emvars.60.20forbidden.3F/near/449962160)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
set_option linter outside of mathlibset_option linter outside of mathlib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
set_optionlinter only emit its warnings in files whose path begins withMathlib,test,Archive,Counterexamples. Effectively, it should disable the linter on projects that are not mathlib.Zulip thread