[Merged by Bors] - chore: remove Data/UnionFind#14556
Closed
[Merged by Bors] - chore: remove Data/UnionFind#14556
Conversation
Its implementation has been improved in lean4lean and batteries; the mathlib implementation can be removed in favour of these. Searching github for 'import Mathlib.Data.UnionFind' only yields forks of mathlib (either explicit or manual); hence this seems safe to remove without a deprecation period.
PR summary e440615b6c
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.UnionFind | 38 | 0 | -38 (-100.00%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Data.UnionFind |
-38 |
Declarations diff
- UFModel
- UFModel.Agrees
- UFModel.Models
- UFNode
- UnionFind
- find
- findAux
- get_eq
- get_eq'
- link
- lt_rankMax
- lt_rankMax'
- mk'
- mkEmpty
- model'
- parent_eq
- parent_eq'
- parent_lt
- rank
- rankMax
- rankMaxAux
- rank_lt
- set
- setParentBump
- size
- union
-- rank_eq
-- setParent
-- size_eq
---- empty
---- push
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Contributor
|
bors d+ |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Thanks for the quick review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Its implementation has been improved in `lean4lean` and `batteries`; the mathlib implementation can be removed in favour of these. Searching github for 'import Mathlib.Data.UnionFind' only yields forks of mathlib (either explicit or manual); hence this seems safe to remove without a deprecation period.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its implementation has been improved in
lean4leanandbatteries; the mathlib implementation can be removed in favour of these.Searching github for 'import Mathlib.Data.UnionFind' only yields forks of mathlib (either explicit or manual); hence this seems safe to remove without a deprecation period.
Search query used: https://github.com/search?q=lang%3ALean+%22import+Mathlib.Data.UnionFind%22&type=code&p=1