Skip to content

[Merged by Bors] - chore: add missing spaces around = or :=#14554

Closed
grunweg wants to merge 3 commits intomasterfrom
MR-spaces-lineends
Closed

[Merged by Bors] - chore: add missing spaces around = or :=#14554
grunweg wants to merge 3 commits intomasterfrom
MR-spaces-lineends

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 9, 2024

Follow mathlib style slightly better: "Use spaces on both sides of ":", ":=" or infix operators."

Automatically generated. Not exhaustive, as doing that everywhere has false positives with meta code.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2024

PR summary f4bbc7e054

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ homologyπ_comp_leftHomologyIso_inv
+ instance {F G : 𝒳 ⥤ᵇ 𝒴} (α : F ⟶ G) [IsIso α] : IsIso (X := F.toFunctor) α.toNatTrans := by
+ instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (swap (· * ·)) (· < ·)] :
+ instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (swap (· * ·)) (· ≤ ·)] :
+ instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (· * ·) (· < ·)] :
+ instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (· * ·) (· ≤ ·)] :
+ stabilizer_card
++-- exact_succ
- homologyπ_comp_leftHomologyIso_inv:
- instance {F G : 𝒳 ⥤ᵇ 𝒴} (α : F ⟶ G) [IsIso α] : IsIso (X:=F.toFunctor) α.toNatTrans := by
- instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (swap (· * ·)) (· < ·)]:
- instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (swap (· * ·)) (· ≤ ·)]:
- instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (· * ·) (· < ·)]:
- instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (· * ·) (· ≤ ·)]:
- stabilizer_card:

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Ruben-VandeVelde
Ruben-VandeVelde approved these changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 9, 2024
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Jul 9, 2024

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 9, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 9, 2024
@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 9, 2024
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 9, 2024

Thanks for the really fast review!

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 9, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
@grunweg
chore: add missing spaces around = or := (#14554)
dfea83f 
Follow mathlib style slightly better: "Use spaces on both sides of ":", ":=" or infix operators."

Automatically generated. Not exhaustive, as doing that everywhere has false positives with meta code.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: add missing spaces around = or := [Merged by Bors] - chore: add missing spaces around = or := Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the MR-spaces-lineends branch July 9, 2024 09:58
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grunweg @jcommelin @Ruben-VandeVelde