[Merged by Bors] - chore(Data.NNRat.Defs): reduce imports#14541
Closed
mattrobball wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore(Data.NNRat.Defs): reduce imports#14541mattrobball wants to merge 3 commits intomasterfrom
mattrobball wants to merge 3 commits intomasterfrom
Conversation
PR summary db3fccb641
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.NNRat.Defs | 458 | 444 | -14 (-3.06%) |
| Mathlib.Data.Nat.Hyperoperation | 504 | 490 | -14 (-2.78%) |
| Mathlib.Data.Int.Star | 523 | 510 | -13 (-2.49%) |
| Mathlib.Data.Rat.Star | 540 | 529 | -11 (-2.04%) |
| Mathlib.NumberTheory.EllipticDivisibilitySequence | 535 | 527 | -8 (-1.50%) |
| Mathlib.Data.Nat.Fib.Basic | 617 | 608 | -9 (-1.46%) |
| Mathlib.Data.Nat.Nth | 658 | 650 | -8 (-1.22%) |
| Mathlib.Data.Num.Prime | 547 | 542 | -5 (-0.91%) |
| Mathlib.Data.Nat.Digits | 658 | 653 | -5 (-0.76%) |
Import changes for all files
| Files | Import difference |
|---|---|
| Too many changes (364)! |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Contributor
|
Looks great; thanks! Feel free to maintainer merge on my behalf. The CI failure looks intermittent; I've just retried it. (Edit: now CI actually runs) |
Contributor
|
CI passes, the changes still look good to me - thank you for doing this! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
A more straightforward proof and we can reduce the explicit imports for `Data.NNRat.Defs` by a third.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A more straightforward proof and we can reduce the explicit imports for
Data.NNRat.Defsby a third.