[Merged by Bors] - chore (Data.Nat.Cast.Field): split into unbundled and bundled results #14536
Closed
mattrobball wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore (Data.Nat.Cast.Field): split into unbundled and bundled results #14536mattrobball wants to merge 4 commits intomasterfrom
mattrobball wants to merge 4 commits intomasterfrom
Conversation
PR summary d4d816339b
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.Nat.Cast.Field | 443 | 318 | -125 (-28.22%) |
| Mathlib.Algebra.CharZero.Lemmas | 457 | 408 | -49 (-10.72%) |
| Mathlib.Data.Int.Interval | 569 | 535 | -34 (-5.98%) |
| Mathlib.Data.ENat.Basic | 470 | 447 | -23 (-4.89%) |
| Mathlib.Combinatorics.SimpleGraph.Coloring | 611 | 594 | -17 (-2.78%) |
Import changes for all files
| Files | Import difference |
|---|---|
| Too many changes (2155)! |
Declarations diff
+ Int.instCovariantClassAddLE
+ Nat.instCovariantClassMulLE
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Contributor
|
Needs a |
grunweg
reviewed
Jul 9, 2024
Contributor
|
I took the liberty to push a simple fix for the archive build failure - I hope you don't mind. (If you do, I'm sorry and will not do so again!) |
2 tasks
grunweg
reviewed
Jul 9, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
I cannot vouch for the change in Mathlib/Algebra/Order/Monoid/Unbundled/Basic.lean; the rest looks good. Thank you for doing this!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
…#14536) We split off the results depending on `LinearOrderedSemifield` into a separate file. Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We split off the results depending on
LinearOrderedSemifieldinto a separate file.