[Merged by Bors] - chore: adaptations for nightly-2024-07-07#14532
Closed
kim-em wants to merge 1 commit intobump/v4.11.0from
Closed
[Merged by Bors] - chore: adaptations for nightly-2024-07-07#14532kim-em wants to merge 1 commit intobump/v4.11.0from
kim-em wants to merge 1 commit intobump/v4.11.0from
Conversation
PR summary 443f8a17ad
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Tactic.Linter.Lint | 3 | 2 | -1 (-33.33%) |
| Mathlib.Algebra.Group.Fin | 319 | 318 | -1 (-0.31%) |
| Mathlib.CategoryTheory.Limits.Shapes.Pullback.Assoc | 404 | 403 | -1 (-0.25%) |
| Mathlib.CategoryTheory.Monoidal.Rigid.Basic | 431 | 430 | -1 (-0.23%) |
| Mathlib.Combinatorics.Additive.PluenneckeRuzsa | 743 | 742 | -1 (-0.13%) |
| Mathlib.Analysis.NormedSpace.Pointwise | 1176 | 1175 | -1 (-0.09%) |
| Mathlib.Topology.Category.Profinite.Nobeling | 1500 | 1499 | -1 (-0.07%) |
| Mathlib.AlgebraicGeometry.Cover.Open | 1530 | 1529 | -1 (-0.07%) |
| Mathlib.MeasureTheory.Function.Jacobian | 1720 | 1719 | -1 (-0.06%) |
| Mathlib.Analysis.SpecialFunctions.Gamma.Beta | 1859 | 1858 | -1 (-0.05%) |
Import changes for all files
| Files | Import difference |
|---|---|
| Too many changes (3916)! |
Declarations diff
- get!_none
- get!_some
- isSome_map
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
eric-wieser
reviewed
Jul 8, 2024
| -- variable [HasPullback (g₂ ≫ f₃) f₄] [HasPullback f₁ (g₃ ≫ f₂)] -/ | ||
| variable [HasPullback (g₂ ≫ f₃) f₄] [HasPullback f₁ ((pullback.fst : Z₂ ⟶ X₂) ≫ f₂)] | ||
| variable | ||
| [HasPullback ((pullback.snd : (pullback f₁ f₂) ⟶ X₂) ≫ f₃) f₄] |
Contributor
Author
There was a problem hiding this comment.
There was a recent change to variables, making its elaboration a bit stricter, and I'm guessing a side effect is that it won't use the local notations above. Didn't investigate further.
Ruben-VandeVelde
approved these changes
Jul 8, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Okay, I guess.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Member
|
LGTM bors merge |
Contributor
|
Pull request successfully merged into bump/v4.11.0. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.