[Merged by Bors] - chore(Data/Set): golf and add decidability of insert#14529
Closed
[Merged by Bors] - chore(Data/Set): golf and add decidability of insert#14529
Conversation
PR summary ee56ab9e2fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Ruben-VandeVelde
approved these changes
Jul 9, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Adds the insert version, golfs existing versions using `inferInstanceAs`. Makes the lemmas all consistent about using `Decidable` vs `DecidablePred`. These decidability instances are useful in downstream applications. Co-authored-by: Bhavik Mehta <bm489@cam.ac.uk>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the insert version, golfs existing versions using
inferInstanceAs.Makes the lemmas all consistent about using
DecidablevsDecidablePred.These decidability instances are useful in downstream applications.