Skip to content

[Merged by Bors] - feat: the (covariant) long exact sequence of Ext#14515

Closed
joelriou wants to merge 150 commits intomasterfrom
ext-covariant-sequence
Closed

[Merged by Bors] - feat: the (covariant) long exact sequence of Ext#14515
joelriou wants to merge 150 commits intomasterfrom
ext-covariant-sequence

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Jul 8, 2024

We obtain the long exact sequence of Ext-groups Ext X S.X₁ n₀ → Ext X S.X₂ n₀ → Ext X S.X₃ n₀ → Ext X S.X₁ n₁ → Ext X S.X₂ n₁ → Ext X S.X₃ n₁ when n₀ + 1 = n₁ and S is a short exact short complex in an abelian category.


Open in Gitpod

joelriou and others added 30 commits June 8, 2024 15:25
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ghost ghost added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Aug 23, 2024
@joelriou joelriou removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 29, 2024
@joelriou joelriou removed the WIP Work in progress label Aug 29, 2024
@dagurtomas
Copy link
Copy Markdown
Contributor

As I understand it, the lemmas covariant_sequence_exact₁' etc. are just auxiliary lemmas for the unprimed versions? Should they maybe be private or in an auxiliary namespace?

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 5, 2024
@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Sep 5, 2024

As I understand it, the lemmas covariant_sequence_exact₁' etc. are just auxiliary lemmas for the unprimed versions? Should they maybe be private or in an auxiliary namespace?

I considers these as alternative formulations: I would keep both in the same namespace, as it is.

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 5, 2024
@dagurtomas
Copy link
Copy Markdown
Contributor

Sorry for the delay!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 26, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

This is great, thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Sep 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Sep 26, 2024
We obtain the long exact sequence of `Ext`-groups `Ext X S.X₁ n₀ → Ext X S.X₂ n₀ → Ext X S.X₃ n₀ → Ext X S.X₁ n₁ → Ext X S.X₂ n₁ → Ext X S.X₃ n₁` when `n₀ + 1 = n₁` and `S` is a short exact short complex in an abelian category.




Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 26, 2024

Build failed:

@dagurtomas
Copy link
Copy Markdown
Contributor

It was the linter for primed lemma names complaining. I've merged master and added docstrings "alternative formulation of ..." to them, are you happy with this @joelriou? Are these docstrings good enough to justify the primed names?

@joelriou
Copy link
Copy Markdown
Contributor Author

It was the linter for primed lemma names complaining. I've merged master and added docstrings "alternative formulation of ..." to them, are you happy with this @joelriou? Are these docstrings good enough to justify the primed names?

Thanks! This is good to me.

@riccardobrasca
Copy link
Copy Markdown
Member

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Sep 26, 2024
We obtain the long exact sequence of `Ext`-groups `Ext X S.X₁ n₀ → Ext X S.X₂ n₀ → Ext X S.X₃ n₀ → Ext X S.X₁ n₁ → Ext X S.X₂ n₁ → Ext X S.X₃ n₁` when `n₀ + 1 = n₁` and `S` is a short exact short complex in an abelian category.




Co-authored-by: dagurtomas <dagurtomas@gmail.com>
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the (covariant) long exact sequence of Ext [Merged by Bors] - feat: the (covariant) long exact sequence of Ext Sep 26, 2024
@mathlib-bors mathlib-bors bot closed this Sep 26, 2024
@mathlib-bors mathlib-bors bot deleted the ext-covariant-sequence branch September 26, 2024 12:37
fbarroero pushed a commit that referenced this pull request Oct 2, 2024
We obtain the long exact sequence of `Ext`-groups `Ext X S.X₁ n₀ → Ext X S.X₂ n₀ → Ext X S.X₃ n₀ → Ext X S.X₁ n₁ → Ext X S.X₂ n₁ → Ext X S.X₃ n₁` when `n₀ + 1 = n₁` and `S` is a short exact short complex in an abelian category.




Co-authored-by: dagurtomas <dagurtomas@gmail.com>
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants