Skip to content

[Merged by Bors] - chore: add test file to import everything#14513

Closed
kim-em wants to merge 4 commits intomasterfrom
import_all
Closed

[Merged by Bors] - chore: add test file to import everything#14513
kim-em wants to merge 4 commits intomasterfrom
import_all

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jul 8, 2024


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 8, 2024

PR summary 775d95dac5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jul 8, 2024

Good idea! (Out of curiosity: were there any bugs in the past caught by this? Or is this just a precaution?)

As a follow-up, would you like to ensure this stays in sync with the lakefile, somehow - or is that an unimportant concern? Feel free to maintainer merge on my behalf once you thought about this.

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jul 9, 2024

Yes, it would be nice to stay in sync, but I coudn't think of an easy way to do this --- we don't want to simply scrape the manifest, because some dependencies (e.g. Cli and ImportGraph) are not used in Mathlib proper so may not have been built by the time the test runs.

I think that dependencies change slowly enough, and the test is not critical, that we can hope for the best here, at least for now.

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jul 9, 2024

Sounds reasonable - so let me
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 9, 2024
@j-loreaux
Copy link
Copy Markdown
Contributor

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: add test file to import everything [Merged by Bors] - chore: add test file to import everything Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the import_all branch July 9, 2024 17:37
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants