[Merged by Bors] - chore: add test file to import everything#14513
[Merged by Bors] - chore: add test file to import everything#14513
Conversation
kim-em
commented
Jul 8, 2024
PR summary 775d95dac5Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
|
Good idea! (Out of curiosity: were there any bugs in the past caught by this? Or is this just a precaution?) As a follow-up, would you like to ensure this stays in sync with the lakefile, somehow - or is that an unimportant concern? Feel free to maintainer merge on my behalf once you thought about this. |
|
Yes, it would be nice to stay in sync, but I coudn't think of an easy way to do this --- we don't want to simply scrape the manifest, because some dependencies (e.g. I think that dependencies change slowly enough, and the test is not critical, that we can hope for the best here, at least for now. |
|
Sounds reasonable - so let me |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |