[Merged by Bors] - chore: Split RingTheory.Trace and RingTheory.Norm#14446
Closed
riccardobrasca wants to merge 12 commits intomasterfrom
Closed
[Merged by Bors] - chore: Split RingTheory.Trace and RingTheory.Norm#14446riccardobrasca wants to merge 12 commits intomasterfrom
RingTheory.Trace and RingTheory.Norm#14446riccardobrasca wants to merge 12 commits intomasterfrom
Conversation
PR summary 62925b1abd
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.NormTrace | 1265 | 1208 | -57 (-4.51%) |
| Mathlib.RingTheory.Complex | 1274 | 1217 | -57 (-4.47%) |
| Mathlib.LinearAlgebra.FreeModule.Norm | 1252 | 1202 | -50 (-3.99%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Trace |
-1263 |
Mathlib.RingTheory.Norm |
-1247 |
Mathlib.RingTheory.Complex Mathlib.RingTheory.NormTrace |
-57 |
Mathlib.LinearAlgebra.FreeModule.Norm |
-50 |
3 filesMathlib.AlgebraicGeometry.EllipticCurve.Group Mathlib.AlgebraicGeometry.EllipticCurve.DivisionPolynomial.Basic Mathlib.AlgebraicGeometry.EllipticCurve.DivisionPolynomial.Degree |
-45 |
8 filesMathlib.FieldTheory.Finite.Trace Mathlib.RingTheory.RootsOfUnity.Lemmas Mathlib.RingTheory.DedekindDomain.IntegralClosure Mathlib.NumberTheory.NumberField.Basic Mathlib.NumberTheory.Cyclotomic.Basic Mathlib.FieldTheory.KummerExtension Mathlib.RingTheory.Polynomial.Eisenstein.IsIntegral Mathlib.NumberTheory.FunctionField |
1 |
35 filesMathlib.RingTheory.FractionalIdeal.Norm Mathlib.NumberTheory.Cyclotomic.Rat Mathlib.NumberTheory.Cyclotomic.Discriminant Mathlib.NumberTheory.GaussSum Mathlib.RingTheory.Localization.NormTrace Mathlib.NumberTheory.NumberField.FractionalIdeal Mathlib.NumberTheory.NumberField.Norm Mathlib.NumberTheory.NumberField.Discriminant Mathlib.NumberTheory.Cyclotomic.PrimitiveRoots Mathlib.Analysis.Fourier.ZMod Mathlib.NumberTheory.Cyclotomic.Three Mathlib.NumberTheory.Cyclotomic.Gal Mathlib.NumberTheory.Cyclotomic.Embeddings Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.NumberField.CanonicalEmbedding.ConvexBody Mathlib.NumberTheory.NumberField.Units.Basic Mathlib.NumberTheory.DirichletCharacter.GaussSum Mathlib.Tactic.NormNum.LegendreSymbol Mathlib.RingTheory.DedekindDomain.Different Mathlib.RingTheory.Discriminant Mathlib.NumberTheory.ClassNumber.Finite Mathlib.NumberTheory.LegendreSymbol.QuadraticChar.GaussSum Mathlib.NumberTheory.LegendreSymbol.JacobiSymbol Mathlib.NumberTheory.LegendreSymbol.AddCharacter Mathlib.RingTheory.IntegralRestrict Mathlib.NumberTheory.Cyclotomic.PID Mathlib.NumberTheory.LegendreSymbol.QuadraticReciprocity Mathlib.NumberTheory.NumberField.Units.DirichletTheorem Mathlib.NumberTheory.ClassNumber.FunctionField Mathlib.NumberTheory.NumberField.Units.Regulator Mathlib.RingTheory.Ideal.Norm Mathlib.NumberTheory.NumberField.Embeddings Mathlib.NumberTheory.NumberField.ClassNumber Mathlib.Tactic Mathlib.NumberTheory.NumberField.CanonicalEmbedding.Basic |
2 |
Mathlib.RingTheory.Norm.Defs |
1166 |
Mathlib.RingTheory.Trace.Defs |
1205 |
Mathlib.RingTheory.Norm.Basic |
1248 |
Mathlib.RingTheory.Trace.Basic |
1264 |
Declarations diff
+ Algebra.traceForm_toMatrix_powerBasis
- traceForm_toMatrix_powerBasis
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>RingTheory.TraceRingTheory.Trace and RingTheory.Norm
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
We split `RingTheory.Trace` in `RingTheory.Trace.Defs` and `RingTheory.Trace.Basic`. Similarly for `RingTheory.Norm`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
RingTheory.Trace and RingTheory.NormRingTheory.Trace and RingTheory.Norm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We split
RingTheory.TraceinRingTheory.Trace.DefsandRingTheory.Trace.Basic. Similarly forRingTheory.Norm.