Skip to content

[Merged by Bors] - feat(Logic/Basic): add simp lemma for @Exists.choose _ (· = a) _#14419

Closed
urkud wants to merge 1 commit intomasterfrom
YK-choose-eq
Closed

[Merged by Bors] - feat(Logic/Basic): add simp lemma for @Exists.choose _ (· = a) _#14419
urkud wants to merge 1 commit intomasterfrom
YK-choose-eq

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jul 4, 2024

and for the symmetric case.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2024

PR summary 6d03e0015a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ choose_eq
+ choose_eq'

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@urkud urkud added awaiting-review t-logic Logic (model theory, etc) labels Jul 4, 2024
@eric-wieser
Copy link
Copy Markdown
Member

!bench

@eric-wieser
Copy link
Copy Markdown
Member

bors d+

Let's check this doesn't fire unexpectedly often and impact performance (and if it does, let's have it without simp)

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 9, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 9, 2024
@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 6d03e00.
There were no significant changes against commit 90e41c5.

@urkud
Copy link
Copy Markdown
Member Author

urkud commented Jul 9, 2024

No significant changes, so merging.
bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Logic/Basic): add simp lemma for @Exists.choose _ (· = a) _ [Merged by Bors] - feat(Logic/Basic): add simp lemma for @Exists.choose _ (· = a) _ Jul 10, 2024
@mathlib-bors mathlib-bors bot closed this Jul 10, 2024
@mathlib-bors mathlib-bors bot deleted the YK-choose-eq branch July 10, 2024 00:53
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants