Skip to content

[Merged by Bors] - doc: fix some author fields in references#14391

Closed
acmepjz wants to merge 2 commits intomasterfrom
acmepjz_bib_1
Closed

[Merged by Bors] - doc: fix some author fields in references#14391
acmepjz wants to merge 2 commits intomasterfrom
acmepjz_bib_1

Conversation

@acmepjz
Copy link
Copy Markdown
Collaborator

@acmepjz acmepjz commented Jul 3, 2024


Open in Gitpod

@acmepjz acmepjz added documentation Improvements or additions to documentation awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 3, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2024

PR summary c381ef07ce

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 3, 2024
@acmepjz
Copy link
Copy Markdown
Collaborator Author

acmepjz commented Jul 3, 2024

I think that \'{\i} is also wrong (it does not render correctly in my WIP pure Lean bibtex diacritic parser leanprover/doc-gen4#200), it should be \'i. Any opinions?

@acmepjz acmepjz changed the title doc: fix an author field in references doc: fix some author fields in references Jul 3, 2024
@faenuccio
Copy link
Copy Markdown
Contributor

I have removed the awaiting-review label according to the decision explained here
https://leanprover.zulipchat.com/#narrow/stream/113486-announce/topic/Changes.20to.20the.20.23queue/near/450176907

@acmepjz
Copy link
Copy Markdown
Collaborator Author

acmepjz commented Jul 9, 2024

I have removed the awaiting-review label according to the decision explained here https://leanprover.zulipchat.com/#narrow/stream/113486-announce/topic/Changes.20to.20the.20.23queue/near/450176907

I see. Sorry for the inconvenience.

@eric-wieser
Copy link
Copy Markdown
Member

I think that \'{\i} is also wrong (it does not render correctly in my WIP pure Lean bibtex diacritic parser leanprover/doc-gen4#200), it should be \'i. Any opinions?

https://tex.stackexchange.com/q/409927/41112 suggests that the original is valid, but unnecessary in modern LaTeX.

bors merge

Thanks!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc: fix some author fields in references [Merged by Bors] - doc: fix some author fields in references Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_bib_1 branch July 9, 2024 23:50
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants