[Merged by Bors] - fix: split alias in no_lost_declarations#14388
Closed
[Merged by Bors] - fix: split alias in no_lost_declarations#14388
alias in no_lost_declarations#14388Conversation
PR summary 09d2548112Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
alias in no_lost_declarations
YaelDillies
approved these changes
Jul 4, 2024
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
This PR is a fix for the mislabeling reported in #13337. It "splits" ```lean [+-]alias ⟨d1, d2⟩ := d ``` into ```lean [+-]alias d1 := d [+-]alias d2 := d ``` before feeding it to the usual filter. Presumably, reproducing the `:= d` parts is irrelevant, but it looks nicer!
Contributor
|
Pull request successfully merged into master. Build succeeded: |
alias in no_lost_declarationsalias in no_lost_declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix for the mislabeling reported in #13337. It "splits"
[+-]alias ⟨d1, d2⟩ := dinto
before feeding it to the usual filter. Presumably, reproducing the
:= dparts is irrelevant, but it looks nicer!