[Merged by Bors] - feat(Mathlib/Data/Matrix/Notation): delaborator for !![a, b; c, d] notation#14376
Closed
[Merged by Bors] - feat(Mathlib/Data/Matrix/Notation): delaborator for !![a, b; c, d] notation#14376
!![a, b; c, d] notation#14376Conversation
Contributor
Komyyy
commented
Jul 3, 2024
PR summary 0288892d5cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
eric-wieser
approved these changes
Jul 10, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Nifty! I'm not super thrilled by the implementation matching on the output of a previous delab, but I also don't have a case in mind where it fails.
I'll let Kyle give it a final check.
!![a, b; c, d] notation!![a, b; c, d] notation
Contributor
|
Thanks! bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
!![a, b; c, d] notation!![a, b; c, d] notation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.