Skip to content

[Merged by Bors] - chore(Data): reduce use of autoImplicit#14362

Closed
grunweg wants to merge 3 commits intomasterfrom
MR-autoImplicit-data
Closed

[Merged by Bors] - chore(Data): reduce use of autoImplicit#14362
grunweg wants to merge 3 commits intomasterfrom
MR-autoImplicit-data

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jul 2, 2024

This is not exhaustive: there are about ten remaining files in this directory.
Data/Vector may come in a follow-up PR (this is harder).


Open in Gitpod

@grunweg grunweg added WIP Work in progress tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jul 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2024

PR summary 6b66961c9e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance {m : Type u → Type v} : ForIn m ByteSlice UInt8
+ instance {α : Type*} {n : ℕ} [DecidableEq α] : DecidableEq (Sym α n)
- instance : ForIn m ByteSlice UInt8
- instance [DecidableEq α] : DecidableEq (Sym α n)

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 8, 2024
@grunweg grunweg added awaiting-review and removed WIP Work in progress labels Jul 8, 2024
@grunweg grunweg changed the title WIP chore(Data): reduce use of autoImplicit chore(Data): reduce use of autoImplicit Jul 8, 2024
Does not touch the files in Vector, which are a bit harder.
@grunweg grunweg force-pushed the MR-autoImplicit-data branch from 60d6294 to aaaa043 Compare July 9, 2024 09:41
@grunweg grunweg removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 9, 2024
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 9, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Jul 9, 2024
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jul 9, 2024

Thank you for the fast review!
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
This is not exhaustive: there are about ten remaining files in this directory.
`Data/Vector` may come in a follow-up PR (this is harder).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data): reduce use of autoImplicit [Merged by Bors] - chore(Data): reduce use of autoImplicit Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the MR-autoImplicit-data branch July 9, 2024 12:42
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants