[Merged by Bors] - chore(Data/Nat): refactor import of Nat/Prime by Nat/Factors#14357
Closed
[Merged by Bors] - chore(Data/Nat): refactor import of Nat/Prime by Nat/Factors#14357
Nat/Prime by Nat/Factors#14357Conversation
PR summary 81018ad08bImport changesDependency changes
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
1 task
Collaborator
Author
|
!bench |
Collaborator
Author
Collaborator
|
Here are the benchmark results for commit 81018ad. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
) Further reduce imports of full `Prime.lean`. Here, `Data.Nat.Factors` now imports only `Prime/Defs`. For this, four lemmas had to be added to `Prime/Defs` from `Prime/Basic`. Many modules import `Data.Nat.Factors`, so their dependencies on `Prime` theorems are now uncovered. Still, this change will reduce the amount of what is imported, in general. Motivation is a circular dependency that would prevent me from adding a lemma to `Prime/Basic`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Nat/Prime by Nat/FactorsNat/Prime by Nat/Factors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further reduce imports of full
Prime.lean. Here,Data.Nat.Factorsnow imports onlyPrime/Defs.For this, four lemmas had to be added to
Prime/DefsfromPrime/Basic. Many modules importData.Nat.Factors, so their dependencies onPrimetheorems are now uncovered. Still, thischange will reduce the amount of what is imported, in general.
Motivation is a circular dependency that would prevent me from adding a lemma to
Prime/Basic.