Conversation
PR summary 99fa7cda24Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Parcly-Taxel
approved these changes
Jul 3, 2024
Contributor
Author
|
Closing in favour of #14378. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
This linter emits a warning at the end of a file if there are unclosed `namespace`s or `section`s. All missing `end`s have been added (automatically) in #14621. Unlike #14352, this PR does leaves outermost `noncomputable section`s open. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/linting.20for.20unclosed.20sections.3F) Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de> Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
This linter emits a warning at the end of a file if there are unclosed `namespace`s or `section`s. All missing `end`s have been added (automatically) in #14621. Unlike #14352, this PR does leaves outermost `noncomputable section`s open. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/linting.20for.20unclosed.20sections.3F) Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de> Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
This linter emits a warning at the end of a file if there are unclosed `namespace`s or `section`s. All missing `end`s have been added (automatically) in #14621. Unlike #14352, this PR does leaves outermost `noncomputable section`s open. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/linting.20for.20unclosed.20sections.3F) Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de> Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This linter emits a warning at the end of a file if there are unclosed
namespaces orsections.Even though the current form of the linter allows the outermost
noncomputable sectionto be left open, the adaptations to the files were done before this change. This means that several files have been modified just to add the missingendto anoncomputable section ... endpair.See #14378 for the same linter, but run on a fresh copy of master with "minimal" modifications to
mathlib.Zulip thread
The addition of the
endwas done by