[Merged by Bors] - chore (Data.Rat.Lemmas): avoid importing OrderedCommMonoid #14341
Closed
mattrobball wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore (Data.Rat.Lemmas): avoid importing OrderedCommMonoid #14341mattrobball wants to merge 1 commit intomasterfrom
OrderedCommMonoid #14341mattrobball wants to merge 1 commit intomasterfrom
Conversation
PR summary a39525ac60Import changesDependency changes
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Member
|
Thanks a lot! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
We can avoid importing `Algebra.Order.Group.Defs` in `Data.Rat.Lemmas` if we use `Nat` versions of some lemmas and slightly modify one proof.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
OrderedCommMonoid OrderedCommMonoid
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
We can avoid importing `Algebra.Order.Group.Defs` in `Data.Rat.Lemmas` if we use `Nat` versions of some lemmas and slightly modify one proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can avoid importing
Algebra.Order.Group.DefsinData.Rat.Lemmasif we useNatversions of some lemmas and slightly modify one proof.We could also exile to
Rat.inv_intCast_den(andRat.inv_natCast_den) toData.Rat.Cast.Lemmassince it doesn't seem to be used.