[Merged by Bors] - chore(Logic): reduce use of autoImplicit#14301
Closed
[Merged by Bors] - chore(Logic): reduce use of autoImplicit#14301
Conversation
The remaining uses are - three declarations in Logic/Basic (which need it, somehow) - in UnivLE, where removing this yields funky errors related to explicit universe levels - in Logic/Equiv/Basic, which is a huge file; fixing it is less trivial
PR summary 4be65ae798Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
The remaining uses are - three declarations in Logic/Basic (which need it, somehow) - in UnivLE, where removing this yields funky errors related to explicit universe levels - in Logic/Equiv/Basic, which is a huge file; fixing it is less trivial
Contributor
|
Pull request successfully merged into master. Build succeeded: |
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
The remaining uses are - three declarations in Logic/Basic (which need it, somehow) - in UnivLE, where removing this yields funky errors related to explicit universe levels - in Logic/Equiv/Basic, which is a huge file; fixing it is less trivial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining uses are