Skip to content

[Merged by Bors] - chore(RingTheory): remove use of autoImplicit#14300

Closed
grunweg wants to merge 1 commit intomasterfrom
MR-autoimplicit-ringtheory
Closed

[Merged by Bors] - chore(RingTheory): remove use of autoImplicit#14300
grunweg wants to merge 1 commit intomasterfrom
MR-autoimplicit-ringtheory

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jun 30, 2024

And delete one porting note which very surely seems non-actionable.


Open in Gitpod

And delete one porting notes which very surely seems non-actionable.
@grunweg grunweg added awaiting-review t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jun 30, 2024
@github-actions
Copy link
Copy Markdown

PR summary 90f16af4f1

Import changes

No significant changes to the import graph


Declarations diff

+ instance {m : ℤ} : AddCommGroup (StandardOneDimIsocrystal p k m)
+ instance {m : ℤ} : Module K(p, k) (StandardOneDimIsocrystal p k m)
- instance : AddCommGroup (StandardOneDimIsocrystal p k m)
- instance : Module K(p, k) (StandardOneDimIsocrystal p k m)

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

mathlib-bors bot pushed a commit that referenced this pull request Jun 30, 2024
And delete one porting note which very surely seems non-actionable.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory): remove use of autoImplicit [Merged by Bors] - chore(RingTheory): remove use of autoImplicit Jun 30, 2024
@mathlib-bors mathlib-bors bot closed this Jun 30, 2024
@mathlib-bors mathlib-bors bot deleted the MR-autoimplicit-ringtheory branch June 30, 2024 23:36
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
And delete one porting note which very surely seems non-actionable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants