[Merged by Bors] - chore(Data/Nat): split Prime.lean#14286
Closed
[Merged by Bors] - chore(Data/Nat): split Prime.lean#14286
Conversation
PR summary 7e4b3ac8c3Import changesDependency changes
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Collaborator
Author
|
The following files now import the shorter Prime/Defs: The follwing files still import the full Prime/Basic (dependency given): |
Contributor
|
!bench |
Collaborator
|
Here are the benchmark results for commit 7e4b3ac. Benchmark Metric Change
============================
- build linting 5.0% |
Contributor
|
@mattrobball, this is just noise, right?? If so, I'm happy to proceed. |
Contributor
|
Yes, we should crank up the limits for this on the benchmarking server |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Splitting `Prime.lean` into `Defs`, `Basic`. The split aims at separation of defs and needed lemmas from everything else. With this split 13/18 Mathlib modules no longer import the whole `Prime.lean`. `Prime/Defs.lean` is about half the size. Motivation is a circular dependency that would prevent me from adding a lemma to `Prime.lean`. https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/split.20Nat.2FPrime.2Elean
Contributor
|
Pull request successfully merged into master. Build succeeded: |
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
Splitting `Prime.lean` into `Defs`, `Basic`. The split aims at separation of defs and needed lemmas from everything else. With this split 13/18 Mathlib modules no longer import the whole `Prime.lean`. `Prime/Defs.lean` is about half the size. Motivation is a circular dependency that would prevent me from adding a lemma to `Prime.lean`. https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/split.20Nat.2FPrime.2Elean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting
Prime.leanintoDefs,Basic. The split aims at separation of defs and needed lemmas from everything else. With this split 13/18 Mathlib modules no longer import the wholePrime.lean.Prime/Defs.leanis about half the size.Motivation is a circular dependency that would prevent me from adding a lemma to
Prime.lean.https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/split.20Nat.2FPrime.2Elean