Skip to content

[Merged by Bors] - feat(SetTheory/Game/PGame): equiv_def and missing Trans instances#14277

Closed
hwatheod wants to merge 3 commits intomasterfrom
hwatheod/missing-Trans-instances
Closed

[Merged by Bors] - feat(SetTheory/Game/PGame): equiv_def and missing Trans instances#14277
hwatheod wants to merge 3 commits intomasterfrom
hwatheod/missing-Trans-instances

Conversation

@hwatheod
Copy link
Copy Markdown
Contributor

@hwatheod hwatheod commented Jun 30, 2024

add equiv_def and missing Trans instances to PGame


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 30, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 30, 2024

PR summary 2f1d4be5d6

Import changes

No significant changes to the import graph


Declarations diff

+ equiv_def
+ instance : Trans
+ instance : Trans (· ≈ ·) (· ⧏ ·) (· ⧏ ·) := ⟨lf_of_equiv_of_lf⟩
+ instance : Trans (· ⧏ ·) (· ≈ ·) (· ⧏ ·) := ⟨lf_of_lf_of_equiv⟩

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@hwatheod hwatheod changed the title feat(Mathlib/SetTheory/Game/PGame): equiv_def and missing Trans instances feat(SetTheory/Game/PGame): equiv_def and missing Trans instances Jun 30, 2024
@YaelDillies YaelDillies added the t-logic Logic (model theory, etc) label Jun 30, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@YaelDillies
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 30, 2024
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 30, 2024
…4277)

add equiv_def and missing Trans instances to PGame
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(SetTheory/Game/PGame): equiv_def and missing Trans instances [Merged by Bors] - feat(SetTheory/Game/PGame): equiv_def and missing Trans instances Jun 30, 2024
@mathlib-bors mathlib-bors bot closed this Jun 30, 2024
@mathlib-bors mathlib-bors bot deleted the hwatheod/missing-Trans-instances branch June 30, 2024 07:15
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants