Skip to content

[Merged by Bors] - feat: convert_to ty at h tactic#14253

Closed
kmill wants to merge 3 commits intomasterfrom
convert_to_at
Closed

[Merged by Bors] - feat: convert_to ty at h tactic#14253
kmill wants to merge 3 commits intomasterfrom
convert_to_at

Conversation

@kmill
Copy link
Copy Markdown
Contributor

@kmill kmill commented Jun 29, 2024

Extends convert_to to be able to operate on any location. When converting the type of a local hypothesis, new congruence goals come first. Suggested on Zulip.

Extends `convert_to` to be able to operate on any location. When converting the type of a local hypothesis, new congruence goals come first.
@kmill kmill added awaiting-review modifies-tactic-syntax This PR adds a new interactive tactic or modifies the syntax of an existing tactic. t-meta Tactics, attributes or user commands labels Jun 29, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 29, 2024

PR summary 5a6203ed7a

Import changes

No significant changes to the import graph


Declarations diff

+ Lean.MVarId.convertLocalDecl
+ elabTermForConvert

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jul 1, 2024

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 1, 2024

✌️ kmill can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Jul 1, 2024
@kmill
Copy link
Copy Markdown
Contributor Author

kmill commented Jul 1, 2024

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Extends `convert_to` to be able to operate on any location. When converting the type of a local hypothesis, new congruence goals come first. Suggested [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/.60convert_to.20at.60.20.2F.20non-definitional.20.60change.60/near/447601320).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 1, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Extends `convert_to` to be able to operate on any location. When converting the type of a local hypothesis, new congruence goals come first. Suggested [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/.60convert_to.20at.60.20.2F.20non-definitional.20.60change.60/near/447601320).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 1, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
Extends `convert_to` to be able to operate on any location. When converting the type of a local hypothesis, new congruence goals come first. Suggested [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/.60convert_to.20at.60.20.2F.20non-definitional.20.60change.60/near/447601320).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: convert_to ty at h tactic [Merged by Bors] - feat: convert_to ty at h tactic Jul 1, 2024
@mathlib-bors mathlib-bors bot closed this Jul 1, 2024
@mathlib-bors mathlib-bors bot deleted the convert_to_at branch July 1, 2024 21:15
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Extends `convert_to` to be able to operate on any location. When converting the type of a local hypothesis, new congruence goals come first. Suggested [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/.60convert_to.20at.60.20.2F.20non-definitional.20.60change.60/near/447601320).
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). modifies-tactic-syntax This PR adds a new interactive tactic or modifies the syntax of an existing tactic. ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants