Skip to content

[Merged by Bors] - chore: reduce imports on the path to LinearMap#14246

Closed
kim-em wants to merge 6 commits intomasterfrom
ring_action_imports
Closed

[Merged by Bors] - chore: reduce imports on the path to LinearMap#14246
kim-em wants to merge 6 commits intomasterfrom
ring_action_imports

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jun 28, 2024


Open in Gitpod

@kim-em kim-em added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 28, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 28, 2024

PR summary c2c36b58c4

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Ring.Action.Basic 369 320 -49 (-13.28%)
Mathlib.GroupTheory.GroupAction.Hom 395 382 -13 (-3.29%)
Mathlib.Algebra.Ring.BooleanRing 520 516 -4 (-0.77%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 29, 2024
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. (You have one typo to fix.)
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

1 similar comment
@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 29, 2024
@sgouezel
Copy link
Copy Markdown
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 29, 2024
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: reduce imports on the path to LinearMap [Merged by Bors] - chore: reduce imports on the path to LinearMap Jun 29, 2024
@mathlib-bors mathlib-bors bot closed this Jun 29, 2024
@mathlib-bors mathlib-bors bot deleted the ring_action_imports branch June 29, 2024 10:04
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants