Conversation
PR summary 78720593bdImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
eric-wieser
left a comment
There was a problem hiding this comment.
This generally looks good; I've left a first round of mostly stylistic comments.
For an alternating form $B : M \times M \to R$ and $a, b, c \in M$ with $a + b+ c = 0$, we have $B(a, b) = B(b, c)$. This can be used to prove the same property of Wronskian: see #14243. Co-authored-by: Seewoo Lee <49933279+seewoo5@users.noreply.github.com>
For an alternating form $B : M \times M \to R$ and $a, b, c \in M$ with $a + b+ c = 0$, we have $B(a, b) = B(b, c)$. This can be used to prove the same property of Wronskian: see #14243. Co-authored-by: Seewoo Lee <49933279+seewoo5@users.noreply.github.com>
|
This PR/issue depends on:
|
|
@eric-wieser Could you help me for setup? I'm trying to understand how the |
For an alternating form $B : M \times M \to R$ and $a, b, c \in M$ with $a + b+ c = 0$, we have $B(a, b) = B(b, c)$. This can be used to prove the same property of Wronskian: see #14243. Co-authored-by: Seewoo Lee <49933279+seewoo5@users.noreply.github.com>
|
With import Mathlib.Algebra.Polynomial.AlgebraMap
import Mathlib.LinearAlgebra.SesquilinearForm
import Mathlib.Algebra.Algebra.Bilinearyou can write variable (R) in
/-- `Polynomial.wronskian` as a bilinear map. -/
def wronskianBilin : R[X] →ₗ[R] R[X] →ₗ[R] R[X] :=
(LinearMap.mul R R[X]).compl₂ derivative - (LinearMap.mul R R[X]).comp derivative
@[simp]
theorem wronskianBilin_apply (a b : R[X]) : wronskianBilin R a b = wronskian a b := rfl |
|
How can I state theorem IsAltwronskianBilin : wronskianBilin.IsAlt := by sorry
theorem IsAltwronskianBilin : LinearMap.IsAlt wronskianBilin := by sorry |
|
That doesn't work because Lean can't work out which |
|
I think I'm almost done assuming theorem IsAltwronskianBilin : (wronskianBilin R).IsAlt := by
intro a
rw [wronskianBilin]
-- sorryand I thought |
|
@eric-wieser I believe it is now ready to be merged - let me know if it needs further updates. |
eric-wieser
left a comment
There was a problem hiding this comment.
maintainer merge
My one lingering question is "are you sure you don't want the n-ary wronskian instead of the binary one?". That could be written as an AlternatingMap.
If you don't want it, let's add that as a TODO in the module docstring.
I'll let someone else give this the final review, but it looks great to me now.
|
🚀 Pull request has been placed on the maintainer queue by eric-wieser. |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
At least for me, I don't need it right now (for polynomial FLT). But I have an (unordinary) application in my mind that uses n-ary Wronskian. The polynomial FLT can be extended to arbitrary number of polynomials as follows: for any algebraically closed characteristic zero field does not admit a non-constant solution in But Wronskian itself is more useful for testing linear independence of sufficiently nice functions, not only polynomials. In that direction, ultimately it would be better to define Wronskian for more general class of functions - or even for abstract rings with derivations - not only for polynomials. So I think it is fine to leave it as-is at this point. |
|
Can you please make the linter happy? Thanks! |
If I understood correctly, this says that the newly added theorem |
|
It's just telling you to remove |
|
Thanks! bors merge |
Define wronskian for polynomials over commutative rings, and prove some basic properties. This is mainly for the porting of our (me and @jcpaik) formalization of [Mason-Stothers theorem](https://github.com/seewoo5/lean-poly-abc). We already discussed about this in [Zulip](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Ring.20with.20derivation/near/447378869). Especially, it may possible to improve as * Replace `CommRing` with `Ring` * or more generally, Wronskian can be defined over any ring with `Derivation`, and most of the theorems we proved should also hold in this context Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Seewoo Lee <49933279+seewoo5@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
Define wronskian for polynomials over commutative rings, and prove some basic properties. This is mainly for the porting of our (me and @jcpaik) formalization of Mason-Stothers theorem. We already discussed about this in Zulip. Especially, it may possible to improve as
CommRingwithRingDerivation, and most of the theorems we proved should also hold in this contextLinearMap.IsAlt.eq_of_add_add_eq_zero#14281