feat: Prove equivalence of isDedekindDomain and isDedekindDomainDvr#14242
Open
feat: Prove equivalence of isDedekindDomain and isDedekindDomainDvr#14242
isDedekindDomain and isDedekindDomainDvr#14242Conversation
…e basic facts about it.
prime, and prove some basic facts about it.
This was referenced Jun 28, 2024
PR summary 83a78b5dcb
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.DedekindDomain.Dvr | 1254 | 1270 | +16 (+1.28%) |
Import changes for all files
| Files | Import difference |
|---|---|
16 filesMathlib.RingTheory.FractionalIdeal.Norm Mathlib.NumberTheory.Cyclotomic.Rat Mathlib.NumberTheory.Cyclotomic.Discriminant Mathlib.NumberTheory.NumberField.FractionalIdeal Mathlib.NumberTheory.NumberField.Discriminant Mathlib.NumberTheory.NumberField.EquivReindex Mathlib.NumberTheory.Cyclotomic.Three Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.NumberField.CanonicalEmbedding.ConvexBody Mathlib.NumberTheory.Cyclotomic.PID Mathlib.NumberTheory.NumberField.Units.DirichletTheorem Mathlib.NumberTheory.NumberField.Units.Regulator Mathlib.RingTheory.Ideal.Norm Mathlib.NumberTheory.NumberField.House Mathlib.NumberTheory.NumberField.ClassNumber Mathlib.NumberTheory.NumberField.CanonicalEmbedding.Basic |
2 |
Mathlib.RingTheory.DedekindDomain.PID |
4 |
Mathlib.RingTheory.DedekindDomain.Dvr |
16 |
Mathlib.RingTheory.FractionalIdeal.LocalizedAtPrime |
1251 |
Declarations diff
+ Field.isLocalization_self
+ IsDedekindDomainDvr.isDedekindDomain
+ IsDedekindDomainDvr.isDedekindDomainInv
+ coe_localizedAtPrime
+ exists_smul_mem_of_mem_localizedAtPrime
+ instance : IsFractionRing Aₚ K
+ instance : IsLocalizedModule P.primeCompl (I.localizedAtPrime_inclusion P)
+ instance : IsScalarTower A Aₚ K
+ isDedekindDomainInv_iff_isDedekindDomainDvr
+ isDedekindDomain_iff_isDedekindDomainDvr
+ localizedAtPrime_add
+ localizedAtPrime_div
+ localizedAtPrime_div_le
+ localizedAtPrime_inclusion
+ localizedAtPrime_inv
+ localizedAtPrime_mul
+ localizedAtPrime_ne_zero
+ localizedAtPrime_one
+ localizedAtPrime_zero
+ mem_localizedAtPrime_iff
+ mem_localizedAtPrime_iff_eq
+ not_le_of_localizedAtPrime_eq_one
+ self_subset_localizedAtPrime
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
…ver-community/mathlib4 into js2357/DedekindDomainDvr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prove that
isDedekindDomainDvris equivalent to bothisDedekindDomainandisDedekindDomainInv.Specifically, prove
isDedekindDomainDvr A → isDedekindDomainInv A, becauseisDedekindDomain A → isDedekindDomainDvr AandIsDedekindDomain A ↔ IsDedekindDomainInv Aare already in Mathlib.