Skip to content

[Merged by Bors] - feat(CategoryTheory): Beck's comonadicity theorem#14238

Closed
mckoen wants to merge 27 commits intomasterfrom
mckoen/AIM_comonadicity3
Closed

[Merged by Bors] - feat(CategoryTheory): Beck's comonadicity theorem#14238
mckoen wants to merge 27 commits intomasterfrom
mckoen/AIM_comonadicity3

Conversation

@mckoen
Copy link
Copy Markdown
Collaborator

@mckoen mckoen commented Jun 28, 2024

Prove Beck's comonadicity theorem by dualizing everything in CategoryTheory.Monad.Monadicity.

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.


Open in Gitpod

@mckoen mckoen added WIP Work in progress t-category-theory Category theory t-algebraic-geometry Algebraic geometry workshop-AIM-AG-2024 This PR is associated with the 2024 AIM workshop on formalization of algebraic geometry labels Jun 28, 2024
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 28, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 28, 2024

PR summary 37d2a649e9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Monad.Comonadicity 555

Declarations diff

+ CreatesLimitOfIsCosplitPair
+ HasEqualizerOfIsCosplitPair
+ PreservesLimitOfIsCoreflexivePair
+ PreservesLimitOfIsCosplitPair
+ ReflectsLimitOfIsCosplitPair
+ comonadicOfCreatesFSplitEqualizers
+ comonadicOfHasPreservesCoreflexiveEqualizersOfReflectsIsomorphisms
+ comonadicOfHasPreservesFSplitEqualizersOfReflectsIsomorphisms
+ comonadicOfHasPreservesReflectsFSplitEqualizers
+ comparisonAdjunction
+ comparisonAdjunction_counit_f
+ comparisonAdjunction_counit_f_aux
+ comparisonAdjunction_unit_app
+ comparisonRightAdjointHomEquiv
+ comparisonRightAdjointObj
+ counitFork
+ counitLimitOfPreservesEqualizer
+ createsFSplitEqualizersOfComonadic
+ instance [CreatesLimitOfIsCosplitPair F] : ∀ (A : Coalgebra adj.toComonad),
+ instance [HasEqualizerOfIsCosplitPair F] : ∀ (A : Coalgebra adj.toComonad),
+ instance [PreservesLimitOfIsCoreflexivePair F] : ∀ X : Coalgebra adj.toComonad,
+ instance [PreservesLimitOfIsCosplitPair F] : ∀ (A : Coalgebra adj.toComonad),
+ instance [ReflectsLimitOfIsCosplitPair F] : ∀ (A : Coalgebra adj.toComonad),
+ instance {A B} (f g : A ⟶ B) [F.IsCosplitPair f g] [CreatesLimitOfIsCosplitPair F] :
+ instance {A B} (f g : A ⟶ B) [F.IsCosplitPair f g] [PreservesLimitOfIsCosplitPair F] :
+ instance {A B} (f g : A ⟶ B) [F.IsCosplitPair f g] [ReflectsLimitOfIsCosplitPair F] :
+ instance {A B} (f g : A ⟶ B) [IsCoreflexivePair f g] [PreservesLimitOfIsCoreflexivePair F] :
+ main_pair_F_cosplit
+ main_pair_coreflexive
+ rightAdjointComparison
+ unitEqualizerOfCoreflectsEqualizer
+ unitFork
+ unitFork_ι

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 28, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 2, 2024
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 10, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 10, 2024
@mckoen mckoen removed the WIP Work in progress label Jul 10, 2024
@mckoen mckoen requested a review from adamtopaz July 17, 2024 21:26
@mckoen mckoen requested a review from dagurtomas August 21, 2024 19:55
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments in the module docstrings of both files Comonadicity and Monadicity to keep them in sync.

You should also merge master and make sure everything works with the new variable incusion mechanism. Otherwise LGTM.

@dagurtomas
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 22, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Aug 22, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 22, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 22, 2024
Prove Beck's comonadicity theorem by dualizing everything in [CategoryTheory.Monad.Monadicity](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Monad/Monadicity.html).

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.



Co-authored-by: dagurtomas <dagurtomas@gmail.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Co-authored-by: Jack McKoen <104791831+mckoen@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): Beck's comonadicity theorem [Merged by Bors] - feat(CategoryTheory): Beck's comonadicity theorem Aug 22, 2024
@mathlib-bors mathlib-bors bot closed this Aug 22, 2024
@mathlib-bors mathlib-bors bot deleted the mckoen/AIM_comonadicity3 branch August 22, 2024 09:16
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Prove Beck's comonadicity theorem by dualizing everything in [CategoryTheory.Monad.Monadicity](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Monad/Monadicity.html).

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.



Co-authored-by: dagurtomas <dagurtomas@gmail.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Co-authored-by: Jack McKoen <104791831+mckoen@users.noreply.github.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Prove Beck's comonadicity theorem by dualizing everything in [CategoryTheory.Monad.Monadicity](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Monad/Monadicity.html).

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.



Co-authored-by: dagurtomas <dagurtomas@gmail.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Co-authored-by: Jack McKoen <104791831+mckoen@users.noreply.github.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
Prove Beck's comonadicity theorem by dualizing everything in [CategoryTheory.Monad.Monadicity](https://leanprover-community.github.io/mathlib4_docs/Mathlib/CategoryTheory/Monad/Monadicity.html).

This contribution was created as part of the AIM workshop "Formalizing Algebraic Geometry" in June 2024.



Co-authored-by: dagurtomas <dagurtomas@gmail.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Co-authored-by: Jack McKoen <104791831+mckoen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry t-category-theory Category theory workshop-AIM-AG-2024 This PR is associated with the 2024 AIM workshop on formalization of algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants