[Merged by Bors] - feat(AlgebraicGeometry/Modules/Tilde): construct the tilde sheaf associated to a module#14231
Closed
weihong-xu wants to merge 14 commits intomasterfrom
Closed
[Merged by Bors] - feat(AlgebraicGeometry/Modules/Tilde): construct the tilde sheaf associated to a module#14231weihong-xu wants to merge 14 commits intomasterfrom
weihong-xu wants to merge 14 commits intomasterfrom
Conversation
PR summary c23de68754Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
3 tasks
joelriou
reviewed
Jun 29, 2024
| /-- | ||
| `M^~` as a sheaf of `𝒪_{Spec R}`-modules | ||
| -/ | ||
| noncomputable def TildeInModules : SheafOfModules (𝒪_SpecR) where |
Contributor
There was a problem hiding this comment.
You should import AlgebraicGeometry.Modules.Sheaf and use Scheme.Modules. Also, a better location for this file would be AlgebraicGeometry.Modules.Tilde.
Collaborator
There was a problem hiding this comment.
I wonder if it is better to make "tilde" inside namespace ModuleCat, so we can use dot notation. What do others think?
Contributor
There was a problem hiding this comment.
ModuleCat.tilde seems good to me.
Collaborator
|
I have put everything inside |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
…ciated to a module (#14231) Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk> Co-authored-by: Johan Commelin <j.m.commelin@uu.nl> Co-authored-by: Amelia Livingston <al3717@ic.ac.uk> Co-authored-by: Sophie Morel <sophie.morel@ens-lyon.fr> Co-authored-by: Jujian Zhang <jujian.zhang1998@gmail.com> This PR was done during the AIM workshop Formalizing Algebraic Geometry. Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com> Co-authored-by: morel <smorel@math.princeton.edu>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Kevin Buzzard k.buzzard@imperial.ac.uk
Co-authored-by: Johan Commelin j.m.commelin@uu.nl
Co-authored-by: Amelia Livingston al3717@ic.ac.uk
Co-authored-by: Sophie Morel sophie.morel@ens-lyon.fr
Co-authored-by: Jujian Zhang jujian.zhang1998@gmail.com
This PR was done during the AIM workshop Formalizing Algebraic Geometry.