[Merged by Bors] - feat(Nat/Factorization): add exists_eq_two_pow_mul_odd#14166
Closed
[Merged by Bors] - feat(Nat/Factorization): add exists_eq_two_pow_mul_odd#14166
exists_eq_two_pow_mul_odd#14166Conversation
PR summary 3fab56ec89Import changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
tb65536
approved these changes
Jun 26, 2024
Contributor
tb65536
left a comment
There was a problem hiding this comment.
LGTM, but someone else should take a look since I helped write it.
exists_eq_two_pow_mul_odd
Member
|
bors merge Thanks! I updated the PR description to explain why I think this lemma is just over the line of "too trivial a consequence of an existing result" |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
Any nonzero natural number is the product of an odd part `m` and a power of two `2 ^ k`. This is a trivial consequence of the existing `exists_eq_pow_mul_and_not_dvd`, but performs a convenient restatement in terms of `Odd`. Needed by #14049. Co-authored-by: Thomas Browning <tb65536@uw.edu>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
exists_eq_two_pow_mul_oddexists_eq_two_pow_mul_odd
1 task
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
Any nonzero natural number is the product of an odd part `m` and a power of two `2 ^ k`. This is a trivial consequence of the existing `exists_eq_pow_mul_and_not_dvd`, but performs a convenient restatement in terms of `Odd`. Needed by #14049. Co-authored-by: Thomas Browning <tb65536@uw.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any nonzero natural number is the product of an odd part
mand a power of two2 ^ k.This is a trivial consequence of the existing
exists_eq_pow_mul_and_not_dvd, but performs a convenient restatement in terms ofOdd.Needed by #14049.
Co-authored-by: Thomas Browning tb65536@uw.edu