Skip to content

[Merged by Bors] - feat: prove the Gagliardo-Nirenberg-Sobolev inequality#14165

Closed
fpvandoorn wants to merge 34 commits intomasterfrom
sobolevinequality
Closed

[Merged by Bors] - feat: prove the Gagliardo-Nirenberg-Sobolev inequality#14165
fpvandoorn wants to merge 34 commits intomasterfrom
sobolevinequality

Conversation

@fpvandoorn
Copy link
Copy Markdown
Member

@fpvandoorn fpvandoorn commented Jun 26, 2024

@fpvandoorn fpvandoorn added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 26, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 26, 2024

PR summary 809a3c5646

Import changes

No significant changes to the import graph


Declarations diff

+ T
+ T_empty
+ T_insert_le_T_lmarginal_singleton
+ T_lmarginal_antitone
+ T_univ
+ argument
+ lintegral_mul_prod_lintegral_pow_le
+ lintegral_pow_le_pow_lintegral_fderiv
+ lintegral_pow_le_pow_lintegral_fderiv_aux
+ lintegral_prod_lintegral_pow_le
+ snormLESNormFDerivOfEqInnerConst
+ snorm_le_snorm_fderiv
+ snorm_le_snorm_fderiv_of_eq
+ snorm_le_snorm_fderiv_of_eq_inner
+ snorm_le_snorm_fderiv_of_le
+ snorm_le_snorm_fderiv_one
+ snorm_restrict_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 26, 2024
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 26, 2024
@ghost
Copy link
Copy Markdown

ghost commented Jun 26, 2024

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 26, 2024

/-- For a function `f` with support in `s`, the Lᵖ norms of `f` with respect to `μ` and
`μ.restrict s` are the same. -/
theorem snorm_restrict_eq {s : Set α} (hs : MeasurableSet s) (hsf : f.support ⊆ s) :
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hs shouldn't be needed: otherwise, use the measurable hull of s instead. Since it contains s, it will also satisfy hsf

Copy link
Copy Markdown
Member Author

@fpvandoorn fpvandoorn Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought that, but I wasn't sure how to get snorm f p (μ.restrict s) = snorm f p (μ.restrict (toMeasurable μ s))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can replace (hs : MeasurableSet s) by [SFinite μ]. Do you think that is better? Both are true in my application.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the lemma, and this is actually nicer. I didn't realize we had to put some effort in making the set measurable when we applied it, so this is a nice simplification.

This does add a small amount of imports to the file LpSpace.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a proof removing the SFinite assumption, but I will first wait for #14260 to be merged, to avoid introducing new lemmas with a wrong name.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #14289

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 27, 2024
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels weird to have this in the MeasureTheory folder; this is firmly a statement in analysis, just like all Sobolev spaces theory. Maybe create a folder Analysis/FunctionalSpaces and put it there?


/-- For a function `f` with support in `s`, the Lᵖ norms of `f` with respect to `μ` and
`μ.restrict s` are the same. -/
theorem snorm_restrict_eq [SFinite μ] {s : Set α} (hsf : f.support ⊆ s) :
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact I think it's possible to get rid also of the SFinite condition, but I'll do that after this PR is merged.


/-! ## The Gagliardo-Nirenberg-Sobolev inequality -/

variable {F : Type*} [NormedAddCommGroup F] [NormedSpace ℝ F] [CompleteSpace F]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The completeness assumption here is probably not necessary, but removing this can definitely wait for another PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #14262

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jun 28, 2024
@fpvandoorn fpvandoorn added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jun 28, 2024
@fpvandoorn
Copy link
Copy Markdown
Member Author

Thanks for your quick reviews!
I don't see how to quickly do the 2 suggested generalizations, so let's leave them for a later PR.
I incorporated your last suggestion, reformulated docstrings with this change, and added a paragraph in the module doc explaining this.

Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 28, 2024

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Jun 28, 2024
@fpvandoorn
Copy link
Copy Markdown
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 28, 2024
* From the Sobolev inequality project

Co-authored-by: Heather Macbeth 25316162+hrmacbeth@users.noreply.github.com
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: prove the Gagliardo-Nirenberg-Sobolev inequality [Merged by Bors] - feat: prove the Gagliardo-Nirenberg-Sobolev inequality Jun 28, 2024
@mathlib-bors mathlib-bors bot closed this Jun 28, 2024
@mathlib-bors mathlib-bors bot deleted the sobolevinequality branch June 28, 2024 22:35
mathlib-bors bot pushed a commit that referenced this pull request Jun 29, 2024
* Forgot to incorporate 1 review comment from #14165
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
* From the Sobolev inequality project

Co-authored-by: Heather Macbeth 25316162+hrmacbeth@users.noreply.github.com
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
* Forgot to incorporate 1 review comment from #14165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants