Skip to content

[Merged by Bors] - chore (Set.Pointwise.Basic): avoid importing ordered rings #14129

Closed
mattrobball wants to merge 4 commits intomasterfrom
mrb/no_ordered_classes_in_submodule_basic
Closed

[Merged by Bors] - chore (Set.Pointwise.Basic): avoid importing ordered rings #14129
mattrobball wants to merge 4 commits intomasterfrom
mrb/no_ordered_classes_in_submodule_basic

Conversation

@mattrobball
Copy link
Copy Markdown
Contributor

We shouldn't need to import ordered algebraic classes for basic properties of pointwise multiplication of sets.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 25, 2024

PR summary 1322b59881

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Set.Pointwise.Basic 412 357 -55 (-13.35%)
Mathlib.Combinatorics.Additive.Dissociation 533 498 -35 (-6.57%)
Mathlib.Data.Set.Semiring 428 416 -12 (-2.80%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@mattrobball mattrobball added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 1, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 1, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jul 1, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
We shouldn't need to import ordered algebraic classes for basic properties of pointwise multiplication of sets.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore (Set.Pointwise.Basic): avoid importing ordered rings [Merged by Bors] - chore (Set.Pointwise.Basic): avoid importing ordered rings Jul 2, 2024
@mathlib-bors mathlib-bors bot closed this Jul 2, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/no_ordered_classes_in_submodule_basic branch July 2, 2024 00:40
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
We shouldn't need to import ordered algebraic classes for basic properties of pointwise multiplication of sets.
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants