Skip to content

[Merged by Bors] - chore (Subgroup.Order): move ordered facts out of Basic and into Order#14121

Closed
mattrobball wants to merge 3 commits intomasterfrom
mrb/keep_ordered_alg_away
Closed

[Merged by Bors] - chore (Subgroup.Order): move ordered facts out of Basic and into Order#14121
mattrobball wants to merge 3 commits intomasterfrom
mrb/keep_ordered_alg_away

Conversation

@mattrobball
Copy link
Copy Markdown
Contributor

We don't want to import the order hierarchy without really needing it.


Open in Gitpod

@mattrobball
Copy link
Copy Markdown
Contributor Author

!bench

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 25, 2024

PR summary ff7d2a7681

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Group.Subgroup.Basic 403 380 -23 (-5.71%)
Mathlib.GroupTheory.Subgroup.Simple 404 393 -11 (-2.72%)
Mathlib.GroupTheory.Archimedean 567 568 +1 (+0.18%)
Mathlib.GroupTheory.Nilpotent 1081 1082 +1 (+0.09%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 9d3f819.
There were no significant changes against commit 0be623a.

@kbuzzard
Copy link
Copy Markdown
Member

kbuzzard commented Jul 1, 2024

Very nice!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
…rder` (#14121)

We don't want to import the order hierarchy without really needing it.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore (Subgroup.Order): move ordered facts out of Basic and into Order [Merged by Bors] - chore (Subgroup.Order): move ordered facts out of Basic and into Order Jul 1, 2024
@mathlib-bors mathlib-bors bot closed this Jul 1, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/keep_ordered_alg_away branch July 1, 2024 23:16
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
…rder` (#14121)

We don't want to import the order hierarchy without really needing it.
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants