[Merged by Bors] - feat(lint-style): rewrite the 'broad imports' linters in Lean#14059
Closed
[Merged by Bors] - feat(lint-style): rewrite the 'broad imports' linters in Lean#14059
Conversation
Also remove the last ERR_OPT reference: that lint is not a syntax linter, so this can safely be removed.
This time, the error codes are intentionally changed, as the old ones feel actively misleading.
PR summary c0c8209c41Import changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
15 tasks
|
This PR/issue depends on: |
Parcly-Taxel
approved these changes
Jun 24, 2024
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
This time, the error codes are intentionally changed, as the old ones feel actively misleading. Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
This time, the error codes are intentionally changed, as the old ones feel actively misleading. Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
This time, the error codes are intentionally changed, as the old ones feel actively misleading. Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
This time, the error codes are intentionally changed, as the old ones feel actively misleading. Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time, the error codes are intentionally changed, as the old ones feel actively misleading.