[Merged by Bors] - feat(Geometry/RingedSpace/OpenImmersion): make IsOpenImmersion instance#14050
Closed
jjaassoonn wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - feat(Geometry/RingedSpace/OpenImmersion): make IsOpenImmersion instance#14050jjaassoonn wants to merge 4 commits intomasterfrom
IsOpenImmersion instance#14050jjaassoonn wants to merge 4 commits intomasterfrom
Conversation
PR summary fc51364d78Import changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
jjaassoonn
commented
Jun 23, 2024
|
|
||
| @[simp] | ||
| theorem isoRestrict_hom_ofRestrict : H.isoRestrict.hom ≫ Y.ofRestrict _ = f := by | ||
| theorem isoRestrict_hom_ofRestrict : (isoRestrict f).hom ≫ Y.ofRestrict _ = f := by |
Collaborator
Author
There was a problem hiding this comment.
Maybe we should change the namespace to enable dot notation as well? @erdOne what do you think?
Collaborator
Author
There was a problem hiding this comment.
It seems
noncomputable def _root_.AlgebraicGeometry.PresheafedSpace.Hom.isoRestrict : X ≅ Y.restrict H.base_open :=will not enable dot notation
jjaassoonn
commented
Jun 23, 2024
| op_id, CategoryTheory.Functor.map_id, Scheme.Hom.invApp, | ||
| PresheafedSpace.IsOpenImmersion.ofRestrict_invApp] | ||
| op_id, CategoryTheory.Functor.map_id, Scheme.Hom.invApp] | ||
| erw [PresheafedSpace.IsOpenImmersion.ofRestrict_invApp] |
Collaborator
Author
There was a problem hiding this comment.
not sure why this got worse
Member
|
LGTM thanks! |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
Contributor
|
Thanks! bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
IsOpenImmersion instanceIsOpenImmersion instance
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.