[Merged by Bors] - feat(lint-style): fix update-style-exceptions.py; produce human-readable output by default#14012
Closed
[Merged by Bors] - feat(lint-style): fix update-style-exceptions.py; produce human-readable output by default#14012
update-style-exceptions.py; produce human-readable output by default#14012Conversation
PR summary 688da36a2dImport changesDependency changes
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
The current error messages are tailored for github annotations, which are not very nice for running the linter locally. Produce a human-readable and -clickable error by default, but add a flag (which CI sets) for producing github-style output. This entails adding a small CLI for the lint-style executable.
273d68e to
7c10d6c
Compare
2 tasks
update-style-exceptions.py; produce human-readable output by default
Contributor
Author
|
I'm happy to split out the "human-readable" part (if desired), but it wouldn't make this PR much shorter. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2024
…dable output by default (#14012) - Fix the output of `update-style-exceptions.py` by making `lake exe lint_style` optionally produce output in the right format: this regressed in #13620 - The current error messages are tailored for github annotations, which are not very readable for running the linter locally. Produce a human-readable and clickable error by default, but add a flag (which CI sets) for producing github-style output. This entails adding a small CLI for the lint-style executable.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
update-style-exceptions.py; produce human-readable output by defaultupdate-style-exceptions.py; produce human-readable output by default
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
…dable output by default (#14012) - Fix the output of `update-style-exceptions.py` by making `lake exe lint_style` optionally produce output in the right format: this regressed in #13620 - The current error messages are tailored for github annotations, which are not very readable for running the linter locally. Produce a human-readable and clickable error by default, but add a flag (which CI sets) for producing github-style output. This entails adding a small CLI for the lint-style executable.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
…dable output by default (#14012) - Fix the output of `update-style-exceptions.py` by making `lake exe lint_style` optionally produce output in the right format: this regressed in #13620 - The current error messages are tailored for github annotations, which are not very readable for running the linter locally. Produce a human-readable and clickable error by default, but add a flag (which CI sets) for producing github-style output. This entails adding a small CLI for the lint-style executable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update-style-exceptions.pyby makinglake exe lint_styleoptionally produce output in the right format: this regressed in [Merged by Bors] - feat: rewrite file length check in Lean #13620This entails adding a small CLI for the lint-style executable.