[Merged by Bors] - fix: setOption linter also recognises a bare profiler option#14006
Closed
[Merged by Bors] - fix: setOption linter also recognises a bare profiler option#14006
profiler option#14006Conversation
Fix a missing edge case in the linter, when an option name had only one component (as in the profiler option), and add a test.
PR summary 9ae6c9a02bImport changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
profiler obtainprofiler option
15 tasks
eric-wieser
reviewed
Jun 30, 2024
eric-wieser
reviewed
Jun 30, 2024
eric-wieser
approved these changes
Jun 30, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
I think the string-processing that caused the bug can be skipped entirely?
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
Fix a missing edge case in the linter, when an option name had only one component (as in the profiler option), and add a test. At the same time, rewrite the linter to use the `name` API (much nicer!), and perform two small clean-ups to the test file.
1 task
eric-wieser
reviewed
Jun 30, 2024
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
|
Ah whatever, it's already on the queue, no need to cancel it to remove those parens |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
profiler optionprofiler option
Contributor
Author
|
Thanks for the review! |
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
Fix a missing edge case in the linter, when an option name had only one component (as in the profiler option), and add a test. At the same time, rewrite the linter to use the `name` API (much nicer!), and perform two small clean-ups to the test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a missing edge case in the linter, when an option name
had only one component (as in the profiler option), and add a test.
At the same time, rewrite the linter to use the
nameAPI (much nicer!), and perform two small clean-ups to the test file.