Skip to content

[Merged by Bors] - feat: the restriction functor on homological complexes#13991

Closed
joelriou wants to merge 9 commits intomasterfrom
embedding-restriction
Closed

[Merged by Bors] - feat: the restriction functor on homological complexes#13991
joelriou wants to merge 9 commits intomasterfrom
embedding-restriction

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Jun 20, 2024

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Jun 20, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 20, 2024 •
edited
Loading

PR summary 6dd9192e53

Import changes

No significant changes to the import graph

Declarations diff

+ instance [HasZeroMorphisms C] : (e.restrictionFunctor C).PreservesZeroMorphisms
+ instance [Preadditive C] : (e.restrictionFunctor C).Additive
+ restriction
+ restrictionFunctor
+ restrictionMap
+ restrictionMap_comp
+ restrictionMap_f'
+ restrictionMap_id
+ restrictionXIso
+ restriction_d_eq

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@joelriou joelriou added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 20, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 20, 2024
callesonne
callesonne reviewed Jun 22, 2024
View reviewed changes
@callesonne callesonne added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jun 22, 2024
joelriou and others added 4 commits June 22, 2024 18:30
@joelriou @callesonne
Update Mathlib/Algebra/Homology/Embedding/Restriction.lean
077dd1c 
Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
@joelriou @callesonne
Update Mathlib/Algebra/Homology/Embedding/Restriction.lean
b1bd82d 
Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
@joelriou @callesonne
Update Mathlib/Algebra/Homology/Embedding/Restriction.lean
3af2793 
Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
@joelriou @callesonne
Update Mathlib/Algebra/Homology/Embedding/Restriction.lean
518a844 
Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
github-actions[bot]
github-actions bot reviewed Jun 22, 2024
View reviewed changes
joelriou and others added 3 commits June 22, 2024 18:31
@joelriou joelriou added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jun 22, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 22, 2024
callesonne
callesonne approved these changes Jun 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@erdOne
Copy link
Copy Markdown
Member

erdOne commented Jun 23, 2024

Thanks! (and thanks Calle!)
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 23, 2024

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 23, 2024
@kbuzzard
Copy link
Copy Markdown
Member

kbuzzard commented Jun 23, 2024

Thanks to everyone involved!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 23, 2024
@joelriou
feat: the restriction functor on homological complexes (#13991)
6cb118d 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the restriction functor on homological complexes [Merged by Bors] - feat: the restriction functor on homological complexes Jun 23, 2024
@mathlib-bors mathlib-bors bot closed this Jun 23, 2024
@mathlib-bors mathlib-bors bot deleted the embedding-restriction branch June 23, 2024 21:44
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
@joelriou @kbuzzard
feat: the restriction functor on homological complexes (#13991)
75b65d1 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@joelriou @dagurtomas
feat: the restriction functor on homological complexes (#13991)
6989cd8 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@callesonne callesonne callesonne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelriou @erdOne @kbuzzard @callesonne