[Merged by Bors] - chore/perf(Analysis): replace continuity -> fun_prop#13959
Closed
[Merged by Bors] - chore/perf(Analysis): replace continuity -> fun_prop#13959
Conversation
This is not exhaustive, but another gradual step towards using fun_prop everywhere possible. In some cases, this speeds up proofs significantly; we also resolve to porting notes about continuity not applying.
PR summary 8108ce1431Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 252d72a. Benchmark Metric Change
======================================================================
+ ~Mathlib.Analysis.Calculus.LineDeriv.Basic instructions -30.2%
+ ~Mathlib.Analysis.InnerProductSpace.Projection instructions -4.5%
+ ~Mathlib.Analysis.SpecialFunctions.Integrals instructions -28.2% |
grunweg
commented
Jun 20, 2024
grunweg
commented
Jun 20, 2024
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 18b00ef. Benchmark Metric Change
===============================================================================
+ ~Mathlib.Analysis.Calculus.LineDeriv.Basic instructions -30.2%
+ ~Mathlib.Analysis.InnerProductSpace.Projection instructions -4.4%
+ ~Mathlib.Analysis.NormedSpace.HahnBanach.SeparatingDual instructions -20.3%
+ ~Mathlib.Analysis.NormedSpace.SphereNormEquiv instructions -71.9%
+ ~Mathlib.Analysis.SpecialFunctions.Integrals instructions -28.2%
+ ~Mathlib.Analysis.SpecialFunctions.Trigonometric.Bounds instructions -23.3% |
Contributor
Author
|
Thank you for the review! I have addressed all comments. |
Contributor
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
This is exhaustive, with the exception of one goal where the `continuity` proof is seemingly not about continuity at all... We tag two lemmas with `fun_prop` which were continuity lemmas. In some cases, this speeds up proofs significantly; we also resolve two porting notes about continuity not applying.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
This is exhaustive, with the exception of one goal where the `continuity` proof is seemingly not about continuity at all... We tag two lemmas with `fun_prop` which were continuity lemmas. In some cases, this speeds up proofs significantly; we also resolve two porting notes about continuity not applying.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
This is exhaustive, with the exception of one goal where the `continuity` proof is seemingly not about continuity at all... We tag two lemmas with `fun_prop` which were continuity lemmas. In some cases, this speeds up proofs significantly; we also resolve two porting notes about continuity not applying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exhaustive, with the exception of one goal where the
continuityproof is seemingly not about continuity at all...We tag two lemmas with
fun_propwhich were continuity lemmas.In some cases, this speeds up proofs significantly; we also resolve two porting notes about continuity not applying.