[Merged by Bors] - chore(Topology): golf, move#13935
Closed
Conversation
Golf and move `Prod.instNeBotNhdsWithinIio` etc.
PR summary fdf0346e6eImport changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
grunweg
reviewed
Jun 18, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thank you for doing this - the changes look good to me!
maintainer merge
| exact forall₂_congr fun U _ ↦ | ||
| ⟨fun h ↦ h (mem_principal_self _), fun h u hsu ↦ h.mono $ inter_subset_inter_right _ hsu⟩ | ||
|
|
||
| @[gcongr] |
Contributor
There was a problem hiding this comment.
For other reviewers: this was just moved (and the gcongr tag is new).
| simp [neBot_iff, nhdsWithin_pi_eq_bot] | ||
| #align nhds_within_pi_ne_bot nhdsWithin_pi_neBot | ||
|
|
||
| instance instNeBotNhdsWithinUnivPi {s : ∀ i, Set (π i)} {x : ∀ i, π i} |
| [∀ i, (𝓝[s i] x i).NeBot] : (𝓝[pi univ s] x).NeBot := by | ||
| simpa [nhdsWithin_pi_neBot] | ||
|
|
||
| instance Pi.instNeBotNhdsWithinIio [Nonempty ι] [∀ i, Preorder (π i)] {x : ∀ i, π i} |
Contributor
There was a problem hiding this comment.
And these proofs are golfed (nice!).
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
Golf and move `Prod.instNeBotNhdsWithinIio` etc.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
Golf and move `Prod.instNeBotNhdsWithinIio` etc.
grunweg
pushed a commit
that referenced
this pull request
Jun 20, 2024
Golf and move `Prod.instNeBotNhdsWithinIio` etc.
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
Golf and move `Prod.instNeBotNhdsWithinIio` etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Golf and move
Prod.instNeBotNhdsWithinIioetc.