[Merged by Bors] - feat(AlgebraicGeometry/ProjectiveSpectrum/Scheme): add the instance IsLocalization#13933
Closed
jjaassoonn wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - feat(AlgebraicGeometry/ProjectiveSpectrum/Scheme): add the instance IsLocalization#13933jjaassoonn wants to merge 3 commits intomasterfrom
IsLocalization#13933jjaassoonn wants to merge 3 commits intomasterfrom
Conversation
PR summary 7d46dd4da0Import changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
7 tasks
added 2 commits
June 18, 2024 16:38
Member
|
Thanks! Edit: to clarify, this is entirely Jujian's work. |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
…IsLocalization` (#13933) If `x` is a point in the basic open set `D(f)` where `f` is a homogeneous element of positive degree, then the homogeneously localized ring `A⁰ₓ` has the universal property of the localization of `A⁰_f` at `φ(x)` where `φ : Proj|D(f) ⟶ Spec A⁰_f` is the morphism of locally ringed space constructed as above. Co-authored-by: Andrew Yang <the.erd.one@gmail.com> Co-authored-by: zjj <j.jj@j.jj>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
IsLocalizationIsLocalization
jcommelin
reviewed
Jun 20, 2024
Comment on lines
+706
to
+708
| @IsLocalization (Away 𝒜 f) _ ((toSpec 𝒜 f).1.base x).asIdeal.primeCompl | ||
| (AtPrime 𝒜 x.1.asHomogeneousIdeal.toIdeal) _ | ||
| (mapId 𝒜 (Submonoid.powers_le.mpr x.2)).toAlgebra := by |
Member
There was a problem hiding this comment.
Can we use named parameters instead of @?
Member
There was a problem hiding this comment.
The instance argument is not named, and it is hard to use letI to massage lean into accepting it. We would need to provide 4 parameters out of 6 anyway.
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
…IsLocalization` (#13933) If `x` is a point in the basic open set `D(f)` where `f` is a homogeneous element of positive degree, then the homogeneously localized ring `A⁰ₓ` has the universal property of the localization of `A⁰_f` at `φ(x)` where `φ : Proj|D(f) ⟶ Spec A⁰_f` is the morphism of locally ringed space constructed as above. Co-authored-by: Andrew Yang <the.erd.one@gmail.com> Co-authored-by: zjj <j.jj@j.jj>
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
…IsLocalization` (#13933) If `x` is a point in the basic open set `D(f)` where `f` is a homogeneous element of positive degree, then the homogeneously localized ring `A⁰ₓ` has the universal property of the localization of `A⁰_f` at `φ(x)` where `φ : Proj|D(f) ⟶ Spec A⁰_f` is the morphism of locally ringed space constructed as above. Co-authored-by: Andrew Yang <the.erd.one@gmail.com> Co-authored-by: zjj <j.jj@j.jj>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
xis a point in the basic open setD(f)wherefis a homogeneous element of positivedegree, then the homogeneously localized ring
A⁰ₓhas the universal property of the localizationof
A⁰_fatφ(x)whereφ : Proj|D(f) ⟶ Spec A⁰_fis the morphism of locally ringed spaceconstructed as above.
Co-authored-by: Andrew Yang the.erd.one@gmail.com