Skip to content

[Merged by Bors] - chore: remove @[simp] from List.join#13888

Closed
kim-em wants to merge 1 commit intomasterfrom
rm_simp_join
Closed

[Merged by Bors] - chore: remove @[simp] from List.join#13888
kim-em wants to merge 1 commit intomasterfrom
rm_simp_join

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jun 17, 2024

Unnecessary, and unhelpful.

@kim-em kim-em added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 17, 2024
@github-actions
Copy link
Copy Markdown

PR summary 6469520260

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@dupuisf
Copy link
Copy Markdown
Contributor

dupuisf commented Jun 19, 2024

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 19, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 19, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove @[simp] from List.join [Merged by Bors] - chore: remove @[simp] from List.join Jun 19, 2024
@mathlib-bors mathlib-bors bot closed this Jun 19, 2024
@mathlib-bors mathlib-bors bot deleted the rm_simp_join branch June 19, 2024 15:07
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants