[Merged by Bors] - chore: reduce use of mono in favour of gcongr#13881
Closed
[Merged by Bors] - chore: reduce use of mono in favour of gcongr#13881
mono in favour of gcongr#13881Conversation
PR summary 80f30d6885Import changesDependency changes
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Mathlib/Algebra/ContinuedFractions/Computation/Approximations.lean
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks! Yes I'm pretty sure those three bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
... as was discussed on zulip the other day; I cannot find the link quickly. After this PR, a handful of uses remain which are harder to remove: [this branch](https://github.com/leanprover-community/mathlib4/compare/MR-mono-gcongr) comments them all
Contributor
|
Come on, bors! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
... as was discussed on zulip the other day; I cannot find the link quickly. After this PR, a handful of uses remain which are harder to remove: [this branch](https://github.com/leanprover-community/mathlib4/compare/MR-mono-gcongr) comments them all
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mono in favour of gcongrmono in favour of gcongr
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
... as was discussed on zulip the other day; I cannot find the link quickly. After this PR, a handful of uses remain which are harder to remove: [this branch](https://github.com/leanprover-community/mathlib4/compare/MR-mono-gcongr) comments them all
grunweg
added a commit
that referenced
this pull request
Jun 20, 2024
... as was discussed on zulip the other day; I cannot find the link quickly. After this PR, a handful of uses remain which are harder to remove: [this branch](https://github.com/leanprover-community/mathlib4/compare/MR-mono-gcongr) comments them all
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
... as was discussed on zulip the other day; I cannot find the link quickly. After this PR, a handful of uses remain which are harder to remove: [this branch](https://github.com/leanprover-community/mathlib4/compare/MR-mono-gcongr) comments them all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as was discussed on zulip the other day; I cannot find the link quickly.
After this PR, a handful of uses remain which are harder to remove: this branch comments them all
Commits can be reviewed independently.
I'd like confirmation that the three lemmas I tagged with gcongr are actually fine to tag.