[Merged by Bors] - chore: replace continuity by fun_prop, easy cases#13880
Closed
[Merged by Bors] - chore: replace continuity by fun_prop, easy cases#13880
continuity by fun_prop, easy cases#13880Conversation
I don't entirely know what I'm doing, please review carefully.
Contributor
Author
|
CC @urkud |
PR summary 6c8558b1f0Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 6c8558b. |
Collaborator
|
Most of the theorems look fine to me. I remember there were some issues with I will investigate the use of |
Collaborator
|
When checking you tagged the right theorem just add option Every |
Contributor
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
Inspired by #12661: let's start with some easy instances, so we can focus on the difficult ones. In particular, this PR does not depend on any in-progress bugfixes, not tries to change a default value `by continuity` to `by fun_prop`. I am not at all confident about the tagging of lemmas with fun_prop: I remember this being subtle, but can't find any documentation on this. @lecopivo Can you advise on these lemmas (or simply link to the right documentation if I just overlooked it)?
Contributor
|
Pull request successfully merged into master. Build succeeded: |
continuity by fun_prop, easy casescontinuity by fun_prop, easy cases
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
Inspired by #12661: let's start with some easy instances, so we can focus on the difficult ones. In particular, this PR does not depend on any in-progress bugfixes, not tries to change a default value `by continuity` to `by fun_prop`. I am not at all confident about the tagging of lemmas with fun_prop: I remember this being subtle, but can't find any documentation on this. @lecopivo Can you advise on these lemmas (or simply link to the right documentation if I just overlooked it)?
grunweg
added a commit
that referenced
this pull request
Jun 20, 2024
Inspired by #12661: let's start with some easy instances, so we can focus on the difficult ones. In particular, this PR does not depend on any in-progress bugfixes, not tries to change a default value `by continuity` to `by fun_prop`. I am not at all confident about the tagging of lemmas with fun_prop: I remember this being subtle, but can't find any documentation on this. @lecopivo Can you advise on these lemmas (or simply link to the right documentation if I just overlooked it)?
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
Inspired by #12661: let's start with some easy instances, so we can focus on the difficult ones. In particular, this PR does not depend on any in-progress bugfixes, not tries to change a default value `by continuity` to `by fun_prop`. I am not at all confident about the tagging of lemmas with fun_prop: I remember this being subtle, but can't find any documentation on this. @lecopivo Can you advise on these lemmas (or simply link to the right documentation if I just overlooked it)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #12661: let's start with some easy instances, so we can focus on the difficult ones.
In particular, this PR does not depend on any in-progress bugfixes, not tries to change a default value
by continuitytoby fun_prop.I am not at all confident about the tagging of lemmas with fun_prop: I remember this being subtle, but can't find any documentation on this. @lecopivo Can you advise on these lemmas (or simply link to the right documentation if I just overlooked it)?