[Merged by Bors] - refactor: move analyticGroupoid to a new file AnalyticManifold.lean#13785
Closed
[Merged by Bors] - refactor: move analyticGroupoid to a new file AnalyticManifold.lean#13785
AnalyticManifold.lean#13785Conversation
I'm about to rewrite the definition of `analyticGroupoid` and define `AnalyticManifold` on top of it, in #10853. @grunweg suggested splitting out the move of `analyticGroupoid` into a separate commit, so that the diff is easier. It used to be in `SmoothManifoldWithCorners.lean`, but this makes no sense as nothing downstream of that file uses `analyticGroupoid`.
PR summary dfcd09900fImport changesDependency changes
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
grunweg
reviewed
Jun 13, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thank you for following up so quickly! This looks good to me (it's straightforward code motion); I like the new module docstring, a happy by-product is that SmoothManifoldWithCorners can shrink a little (that file is quite large anyway).
I just have one comment about the copyright header.
AnalyticManifold.lean
Contributor
|
Thanks for the swift response! I still think this looks good, so let's |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
AnalyticManifold.leanAnalyticManifold.lean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be in
SmoothManifoldWithCorners.lean, but this makes no sense as nothing downstream of that file usesanalyticGroupoid. In #10853, I will rewrite the definition ofanalyticGroupoidand defineAnalyticManifoldon top of it.